feat: add getActivePiecesByCursor for gas-efficient pagination#246
Merged
rvagg merged 2 commits intoFilOzone:mainfrom Feb 3, 2026
Merged
Conversation
rvagg
reviewed
Jan 29, 2026
rvagg
reviewed
Jan 29, 2026
rvagg
reviewed
Jan 30, 2026
rvagg
approved these changes
Feb 3, 2026
Contributor
rvagg
left a comment
There was a problem hiding this comment.
Merging, but this isn't going live until we can schedule an upgrade
Contributor
|
Thanks @Chaitu-Tatipamula, good work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #243 - Adds
getActivePiecesByCursorfunction that uses cursor-based pagination with O(limit) gas complexity, avoiding the gas exhaustion issue withgetActivePiecesat high offsets.Changes
getActivePiecesByCursor(setId, startPieceId, limit)- starts fromstartPieceIdinstead of scanning from 0getActivePiecesabout O(offset) gas complexityUsage