Skip to content

refactor: follow CEI pattern in provePossession #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akronim26 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: follow CEI pattern in provePossession #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PDPVerifier.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ contract PDPVerifier is Initializable, UUPSUpgradeable, OwnableUpgradeable {
//
// (add 32 bytes to the `callDataSize` to also account for the `setId` calldata param)
uint256 refund = calculateAndBurnProofFee(setId);
dataSetLastProvenEpoch[setId] = block.number;

{
address listenerAddr = dataSetListener[setId];
Expand All @@ -678,7 +679,6 @@ contract PDPVerifier is Initializable, UUPSUpgradeable, OwnableUpgradeable {
}
}

dataSetLastProvenEpoch[setId] = block.number;
emit PossessionProven(setId, challenges);

// Return the overpayment after doing everything else to avoid re-entrancy issues (all state has been updated by this point). If this
Expand Down
Loading