Skip to content

Conversation

@rvagg
Copy link
Contributor

@rvagg rvagg commented Jan 30, 2026

@rvagg rvagg requested review from ZenGround0 and rjan90 January 30, 2026 03:41
@FilOzzy FilOzzy added this to FOC Jan 30, 2026
@github-project-automation github-project-automation bot moved this to 📌 Triage in FOC Jan 30, 2026
@rvagg rvagg force-pushed the rvagg/spec-and-known-issues-upd branch 2 times, most recently from f85ff26 to 5bd4b87 Compare January 30, 2026 03:49
- Add Known Issues section documenting lockupUsage leak (#274)
- Add versioning note to SPEC.md for v1-specific behaviours
- Document validator note accumulation behavior (#268)
- Document lockupUsage caveat during finalization
@rvagg rvagg force-pushed the rvagg/spec-and-known-issues-upd branch from 5bd4b87 to cbca0ed Compare January 30, 2026 03:50
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage        ?   76.43%           
=======================================
  Files           ?        5           
  Lines           ?      539           
  Branches        ?      105           
=======================================
  Hits            ?      412           
  Misses          ?      122           
  Partials        ?        5           
Flag Coverage Δ
foundry 76.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Jan 30, 2026
@rjan90 rjan90 moved this to ✔️ Approved by reviewer in Payments Jan 30, 2026
@rjan90 rjan90 added this to the M4.0: mainnet staged milestone Jan 30, 2026
@rjan90 rjan90 merged commit a834f23 into main Jan 30, 2026
6 checks passed
@rjan90 rjan90 deleted the rvagg/spec-and-known-issues-upd branch January 30, 2026 14:57
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Jan 30, 2026
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in Payments Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants