Skip to content

Audit fix gross settlement check #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZenGround0 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Audit fix gross settlement check #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9883457
fix(settlement): use requiredLockup in lockup sufficiency check
Jan 28, 2026
9eecda4
Cleanup
Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/FilecoinPayV1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,13 +1463,14 @@ contract FilecoinPayV1 is ReentrancyGuard {
Errors.InsufficientFundsForSettlement(rail.token, rail.from, grossSettledAmount, payer.funds)
);

uint256 actualSettledDuration = settledUntilEpoch - epochStart;
uint256 requiredLockup = rate * actualSettledDuration;

// Verify payer has sufficient lockup for the settlement
require(
payer.lockupCurrent >= grossSettledAmount,
Errors.InsufficientLockupForSettlement(rail.token, rail.from, payer.lockupCurrent, grossSettledAmount)
payer.lockupCurrent >= requiredLockup,
Errors.InsufficientLockupForSettlement(rail.token, rail.from, payer.lockupCurrent, requiredLockup)
);
uint256 actualSettledDuration = settledUntilEpoch - epochStart;
uint256 requiredLockup = rate * actualSettledDuration;

// Transfer funds from payer (always pays full settled amount)
payer.funds -= grossSettledAmount;
Expand Down
Loading