Audit fix gross settlement check #270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per audit recommendation, the lockup check now compares against requiredLockup instead of grossSettledAmount. This is more direct since requiredLockup is what we actually subtract from lockupCurrent. The calculation of actualSettledDuration and requiredLockup is moved before the check to make the comparison possible. Fixes #267 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
wjmelements
approved these changes
Jan 29, 2026
Collaborator
wjmelements
left a comment
wjmelements
left a comment
There was a problem hiding this comment.
This is safe because solidity also does this check on the line
payer.lockupCurrent -= requiredLockup
If we are handling this underflow case with a custom error, we can make that subtraction unchecked.
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267