Skip to content

feat: [sc-478107] Allow explicitly specifying gas limit#14

Merged
rpatel-figure merged 2 commits intomainfrom
ravipatel/sc-478107/try-doubling-gas-estimates
Feb 12, 2026
Merged

feat: [sc-478107] Allow explicitly specifying gas limit#14
rpatel-figure merged 2 commits intomainfrom
ravipatel/sc-478107/try-doubling-gas-estimates

Conversation

@rpatel-figure
Copy link
Copy Markdown
Contributor

@rpatel-figure rpatel-figure commented Feb 12, 2026

Context

The default fee estimating logic sometimes fails when dealing with relatively larger specification updates. We can allow consumers to override the calculated gas limit.

Changes

  • Allow gas limit to be hardcoded to override what the message fee client would otherwise calculate
  • Clean up a few code smells

Note

Medium Risk
Touches transaction fee/gas estimation and broadcasting behavior; an incorrect fixed limit could cause tx failures or unintended fees when publishing specs.

Overview
Adds a new fixedGasLimit configuration on P8eLocationExtension, documented in the README, to allow consumers to override the gas limit used for tx fee estimation.

Updates ProvenanceClient to use a custom gas estimator that still queries the msg-fee service for fees but applies the configured fixed limit when set; includes a small Kotlin destructuring cleanup in Bootstrapper.

Written by Cursor Bugbot for commit 2427cc9. This will update automatically on new commits. Configure here.

@rpatel-figure rpatel-figure requested a review from a team as a code owner February 12, 2026 21:56
@rpatel-figure rpatel-figure added feature A new functional addition patch A backwards-compatible bug fix or configuration updates (should follow semantic versioning) labels Feb 12, 2026
Copy link
Copy Markdown

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@github-actions
Copy link
Copy Markdown

Test Results

1 files  ±0  1 suites  ±0   4s ⏱️ ±0s
5 tests ±0  5 ✅ ±0  0 💤 ±0  0 ❌ ±0 
9 runs  ±0  9 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2427cc9. ± Comparison against base commit 6c3b96f.

@rpatel-figure rpatel-figure merged commit 7271d98 into main Feb 12, 2026
9 checks passed
@rpatel-figure rpatel-figure deleted the ravipatel/sc-478107/try-doubling-gas-estimates branch February 12, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new functional addition patch A backwards-compatible bug fix or configuration updates (should follow semantic versioning)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants