fix(branching): cross-repo PR builds fail#176
Draft
tbcrawford wants to merge 3 commits intoFigureTechnologies:mainfrom
Draft
fix(branching): cross-repo PR builds fail#176tbcrawford wants to merge 3 commits intoFigureTechnologies:mainfrom
tbcrawford wants to merge 3 commits intoFigureTechnologies:mainfrom
Conversation
4e6bc4a to
92867b5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| override fun getLeaf(): Ref = this | ||
|
|
||
| override fun getTarget(): Ref? = null |
There was a problem hiding this comment.
SyntheticRef.getTarget() violates JGit Ref interface contract
Medium Severity
SyntheticRef.getTarget() returns null, but the JGit Ref interface contract specifies that when isSymbolic() is false, getTarget() must return this. All standard JGit non-symbolic ref implementations (e.g., ObjectIdRef) follow this contract. Returning null here could cause a NullPointerException if the ref is ever passed to JGit APIs or other code that relies on the documented non-null guarantee for non-symbolic refs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Changes how the current git ref is determined in CI and alters commit-count resolution fallback behavior, which can affect version strings produced on build pipelines.
Overview
Fixes version calculation in CI for forked/cross-repository GitHub pull requests where
GITHUB_HEAD_REFpoints to a branch that doesn’t exist in the checked-out repo.Branch.currentRefnow falls back to a syntheticRefnamed fromGITHUB_HEAD_REF(otherwiseHEAD) instead of failing, andBranchList.commitCountBetweenfalls back to resolvingHEADwhen the target ref can’t be resolved.Adds a new functional test suite (
CrossRepositoryPullRequestSpec) covering: missing local branch withGITHUB_HEAD_REF, preferringGITHUB_HEAD_REFoverGITHUB_REF_NAME, and falling back toGITHUB_REF_NAMEwhenGITHUB_HEAD_REFis empty.Written by Cursor Bugbot for commit 92867b5. This will update automatically on new commits. Configure here.