Skip to content

Conversation

@LeoFalco
Copy link
Member

@LeoFalco LeoFalco commented Jan 7, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 7, 2026 21:35
@LeoFalco LeoFalco self-assigned this Jan 7, 2026
@LeoFalco LeoFalco merged commit de94b9f into master Jan 7, 2026
2 of 3 checks passed
@LeoFalco LeoFalco deleted the chore/codeowners-governance branch January 7, 2026 21:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces code ownership governance by adding a CODEOWNERS file to standardize review requirements. The file establishes default ownership by @FieldControl/shared for all files and specialized ownership by @FieldControl/codeowners for CI/CD infrastructure in the .github/ directory.

  • Adds CODEOWNERS file with two ownership rules
  • Sets @FieldControl/shared as default owner for the repository
  • Designates @FieldControl/codeowners as owner for .github/ directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +3
* @FieldControl/shared

/.github/ @FieldControl/codeowners
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of rules in CODEOWNERS files matters. More specific patterns should be placed before general patterns because GitHub uses the last matching pattern. Currently, the general wildcard pattern * @FieldControl/shared appears first, which means it will override the more specific /.github/ @FieldControl/codeowners rule. This means all files, including those in .github/, will be owned by @FieldControl/shared instead of @FieldControl/codeowners.

The rules should be reordered so that /.github/ @FieldControl/codeowners comes before * @FieldControl/shared.

Suggested change
* @FieldControl/shared
/.github/ @FieldControl/codeowners
/.github/ @FieldControl/codeowners
* @FieldControl/shared

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants