Feature/decimation #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZueFe
reviewed
Oct 20, 2016
| * @param e | ||
| */ | ||
| private void contractEdge(Edge e) { | ||
| System.out.println("Starting edge " + e.getFrom() + " to " + e.getTo()); |
ZueFe
reviewed
Oct 20, 2016
|
|
||
| // reattach all triangles adjacent to FROM to the moved TO | ||
| // FROM should be removed, with faces that would degenerate to 2D | ||
| // TODO: actually remove correct faces and vertices |
Collaborator
Author
There was a problem hiding this comment.
- to TODO som tam zabudol :D
- ako myslis ci to vobec robi decimaciu? zato ze sa neodstranuju vrcholy? ako chces pocas vypoctu odstranovat vrcholy z datovej struktury ktora je popisana zoznamom bodov a vsetko je identifikovane pomocou indexu?
Collaborator
There was a problem hiding this comment.
nah, len podrypujem, myslela som na TODO ~~
Collaborator
Author
There was a problem hiding this comment.
No, ono tam uz nema byt, odstranovanie toho co netreba sa robi na konci (takze sa to naozaj robi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic version of quadric edge collapse decimation which can be substantially improved in many ways