Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
architect-dev
left a comment
architect-dev
left a comment
There was a problem hiding this comment.
Everything looks good, the docs are a little verbose but good. One of the comments is about a trust assumption with the way I've implemented the validation - the read contract call will make the ctHash visible to the node operator. I think it would be better to switch back to a local ecrecover and instead fetch (cache?) the sender address from the task manager. Wdyt?
| @@ -0,0 +1,79 @@ | |||
| --- | |||
| title: Verifying Decrypt Results | |||
| description: Validate Threshold Network decrypt signatures received from relayers/backends/caches | |||
There was a problem hiding this comment.
This looks to have some zama stuff in it
|
|
||
| The “signer is correct” part refers to the **Threshold Network’s signing key** (a distributed key controlled by the Threshold Network committee), not your wallet address. A `true` result means the chain’s verifier considers this signature a valid attestation from that Threshold Network key for the specific `(ctHash, plaintext)` pair. | ||
|
|
||
| Under the hood, this is an `eth_call` to the chain’s TaskManager verifier (no gas), returning a boolean. |
There was a problem hiding this comment.
I'm actually realizing that the implementation that I put in is the wrong one. The public call reveals the value of the ctHash to the node, really I should have done it with a local ecrecover to handle this. The reason I didn't is that signer is a variable in TaskManager so it was easier to do an eth_call. I think instead we should go back to the ecrecover, and use an eth_cal to read the signer address to check against.
2 participants
No description provided.