Fix for Update dependencies 2025-12-08#11
Merged
thiagofloriano merged 6 commits intomainfrom Dec 10, 2025
Merged
Conversation
thiagofloriano
requested changes
Dec 10, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes an initialization order issue that occurred after a bundle upgrade, where VitalsImage::TagHelper was being referenced before it was loaded, causing an uninitialized constant error.
- Adds explicit require for the TagHelper module to ensure it's loaded before use
- Addresses a breaking change introduced by dependency updates affecting module loading order
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thiagofloriano
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/FestaLab/festalab-app/pull/9120
This PR will be needed to fix the following error that was happening after de bundle upgrade on our dependency updates.
The error was happening on line 91 of the vitals_image/lib/vitals_image/engine.rb: file, when we called the TagHelper before it was initialized by the application.
"bin/rails aborted!
18:58:58 web.1 | /home/lucas/code/Festalab/vitals_image/lib/vitals_image/engine.rb:91:in 'block (2 levels) in class:Engine': uninitialized constant VitalsImage::TagHelper (NameError)
18:58:58 web.1 | helper VitalsImage::TagHelper
18:58:58 web.1 | from /home/lucas/.local/share/mise/installs/ruby/3.4.4/lib/ruby/gems/3.4.0/bundler/gems/rails-45d7ba97b07e/activesupport/lib/active_support/lazy_load_hooks.rb:97:in 'Module#class_eval'