feat: add fullscreen toggle functionality to NavLayout component#52
Merged
FelizCoder merged 2 commits intomainfrom Jun 26, 2025
Merged
feat: add fullscreen toggle functionality to NavLayout component#52FelizCoder merged 2 commits intomainfrom
FelizCoder merged 2 commits intomainfrom
Conversation
80ed2e1 to
2f6286a
Compare
- renders only once mounted, not on every refresh
There was a problem hiding this comment.
Pull Request Overview
Adds a fullscreen toggle button to the NavLayout component, enabling users to enter and exit browser fullscreen mode.
- Imported fullscreen icons and added
isFullscreenstate withtoggleFullscreenhandler - Updated
useEffectto listen forfullscreenchangeevents and clean up - Adjusted header layout to include both collapse and fullscreen buttons
Comments suppressed due to low confidence (1)
app/ui/navigation/NavLayout.tsx:26
- The new fullscreen toggle logic isn’t covered by existing tests. Consider adding unit or integration tests that mock
document.fullscreenElementand verify thatisFullscreenstate updates correctly whentoggleFullscreenand thefullscreenchangeevent fire.
const toggleFullscreen = () => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #51