Skip to content

feat: add fullscreen toggle functionality to NavLayout component#52

Merged
FelizCoder merged 2 commits intomainfrom
51-add-a-buton-to-toggle-fullscreen-mode
Jun 26, 2025
Merged

feat: add fullscreen toggle functionality to NavLayout component#52
FelizCoder merged 2 commits intomainfrom
51-add-a-buton-to-toggle-fullscreen-mode

Conversation

@FelizCoder
Copy link
Owner

closes #51

Copilot AI review requested due to automatic review settings June 26, 2025 20:02
@FelizCoder FelizCoder linked an issue Jun 26, 2025 that may be closed by this pull request

This comment was marked as outdated.

@FelizCoder FelizCoder force-pushed the 51-add-a-buton-to-toggle-fullscreen-mode branch from 80ed2e1 to 2f6286a Compare June 26, 2025 20:11
- renders only once mounted, not on every refresh
@FelizCoder FelizCoder requested a review from Copilot June 26, 2025 20:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a fullscreen toggle button to the NavLayout component, enabling users to enter and exit browser fullscreen mode.

  • Imported fullscreen icons and added isFullscreen state with toggleFullscreen handler
  • Updated useEffect to listen for fullscreenchange events and clean up
  • Adjusted header layout to include both collapse and fullscreen buttons
Comments suppressed due to low confidence (1)

app/ui/navigation/NavLayout.tsx:26

  • The new fullscreen toggle logic isn’t covered by existing tests. Consider adding unit or integration tests that mock document.fullscreenElement and verify that isFullscreen state updates correctly when toggleFullscreen and the fullscreenchange event fire.
  const toggleFullscreen = () => {

@FelizCoder FelizCoder merged commit 5675b72 into main Jun 26, 2025
2 checks passed
@FelizCoder FelizCoder deleted the 51-add-a-buton-to-toggle-fullscreen-mode branch June 26, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a buton to toggle fullscreen mode

1 participant

Comments