Skip to content

Add Finglish month names jalali formatter#29

Merged
FatulM merged 2 commits intoFatulM:masterfrom
AshkanWatson:master
Jul 15, 2025
Merged

Add Finglish month names jalali formatter#29
FatulM merged 2 commits intoFatulM:masterfrom
AshkanWatson:master

Conversation

@AshkanWatson
Copy link
Copy Markdown
Contributor

I needed the month names in Finglish for my personal project, and i thought it might be useful for others as well. so i added a simple constant list of month names in Finglish as monthNamesFinglish , and a simple getter mNF to access the current date's month name in Finglish

Let me know if you have any feedback or suggestion!

I needed the month names in Finglish for my personal project, and i thought it might be useful for others as well.
so i added a simple  constant list of month names in Finglish as monthNamesFinglish , and a simple getter mNF to access the current date's month name in Finglish

Let me know if you have any feedback or suggestion!
@FatulM FatulM self-assigned this Jul 8, 2025
@FatulM FatulM added the enhancement New feature or request label Jul 8, 2025
@FatulM
Copy link
Copy Markdown
Owner

FatulM commented Jul 11, 2025

Hi,
Thanks.
please make your month name list field private like the other month name list fields.
can you add tests ?
check mNAf which i have added tests for it.
Also rename the getter to something like mNFin or mNFn ...

Copy link
Copy Markdown
Owner

@FatulM FatulM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AshkanWatson
Copy link
Copy Markdown
Contributor Author

Thank you for your reply, @FatulM.
I've added tests for mNF, and also included wNFn for Finglish week names.
Additionally, I created an example using j1, and all test have passed successfully.

Copy link
Copy Markdown
Owner

@FatulM FatulM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
I will merge this PR

@FatulM FatulM merged commit 270037b into FatulM:master Jul 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants