Skip to content

Fix #343 (Afterburner fails on unknown properties) #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowtowncoder merged 1 commit into from
Apr 13, 2026
+10 −2
Merged

Fix #343 (Afterburner fails on unknown properties) #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion afterburner/src/main/java/tools/jackson/module/afterburner/deser/ABDeserializerModifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public BeanDeserializerBuilder updateBuilder(DeserializationConfig config,
// [module-afterburner#21]: Can't force access to sealed packages, or anything within "java."
if (!MyClassLoader.canAddClassInPackageOf(beanClass)) {
return builder;
}
}
/* Hmmh. Can we access stuff from private classes?
* Possibly, if we can use parent class loader.
* (should probably skip all non-public?)
Expand Down
3 changes: 2 additions & 1 deletion ...rner/src/main/java/tools/jackson/module/afterburner/deser/SuperSonicBeanDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ public Object deserializeFromObject(JsonParser p, DeserializationContext ctxt)
}
// also, need to ensure we get closing END_OBJECT...
if (p.nextToken() != JsonToken.END_OBJECT) {
return _handleUnexpectedWithin(p, ctxt, bean);
// [modules-base#343]: trailing (possibly unknown) properties remain
return _deserializeDisordered(p, ctxt, bean);
}
return bean;
}
Expand Down
7 changes: 7 additions & 0 deletions release-notes/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ Active maintainers:

No changes since 3.1

3.1.3 (not yet released)

#343: Deserialization Failed when an unknown property is added in JSON
when using Afterburner Module
(reported by @leowongkh)
(fix by @cowtowncoder, w/ Claude code)

3.1.2 (11-Apr-2026)
3.1.1 (27-Mar-2026)

Expand Down