Skip to content

Fix search query sanitization #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fastbyte01 merged 1 commit into from
Jun 27, 2025
Merged

Fix search query sanitization #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions assets/js/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ class Util {
if (!reserved) element.addEventListener('animationend', handler, false);
}

escapeHTML(str) {
const div = document.createElement('div');
div.textContent = str;
return div.innerHTML;
}

}

class Theme {
Expand Down Expand Up @@ -319,10 +325,18 @@ class Theme {
title,
date,
context
}) => `<div><span class="suggestion-title">${title}</span><span class="suggestion-date">${date}</span></div><div class="suggestion-context">${context}</div>`,
}, {
query
}) => {
const safeQuery = this.util.escapeHTML(query);
return `<div data-query="${safeQuery}"><span class="suggestion-title">${title}</span><span class="suggestion-date">${date}</span></div><div class="suggestion-context">${context}</div>`;
},
empty: ({
query
}) => `<div class="search-empty">${searchConfig.noResultsFound}: <span class="search-query">"${query}"</span></div>`,
}) => {
const safeQuery = this.util.escapeHTML(query);
return `<div class="search-empty">${searchConfig.noResultsFound}: <span class="search-query">"${safeQuery}"</span></div>`;
},
footer: ({}) => {
const {
searchType,
Expand Down
16 changes: 14 additions & 2 deletions src/js/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ class Util {
};
if (!reserved) element.addEventListener('animationend', handler, false);
}

escapeHTML(str) {
const div = document.createElement('div');
div.textContent = str;
return div.innerHTML;
}
}

class Theme {
Expand Down Expand Up @@ -272,8 +278,14 @@ class Theme {
}
},
templates: {
suggestion: ({ title, date, context }) => `<div><span class="suggestion-title">${title}</span><span class="suggestion-date">${date}</span></div><div class="suggestion-context">${context}</div>`,
empty: ({ query }) => `<div class="search-empty">${searchConfig.noResultsFound}: <span class="search-query">"${query}"</span></div>`,
suggestion: ({ title, date, context }, { query }) => {
const safeQuery = this.util.escapeHTML(query);
return `<div data-query="${safeQuery}"><span class="suggestion-title">${title}</span><span class="suggestion-date">${date}</span></div><div class="suggestion-context">${context}</div>`;
},
empty: ({ query }) => {
const safeQuery = this.util.escapeHTML(query);
return `<div class="search-empty">${searchConfig.noResultsFound}: <span class="search-query">"${safeQuery}"</span></div>`;
},
footer: ({}) => {
const { searchType, icon, href } = searchConfig.type === 'algolia' ? {
searchType: 'algolia',
Expand Down
Loading