Skip to content

Ensure @override is added to every overriding method/property #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FancyNeuron merged 1 commit into from
Jul 19, 2025
Merged

Ensure @override is added to every overriding method/property #74

FancyNeuron merged 1 commit into from
Jul 19, 2025

Conversation

@FancyNeuron
Copy link
Owner

@FancyNeuron FancyNeuron commented Jul 19, 2025

Add @OverRide decorators and test that enforces decorator on overriding methods/properties

@FancyNeuron FancyNeuron linked an issue Jul 19, 2025 that may be closed by this pull request
Add @override to all overriding methods #71
Closed
@FancyNeuron FancyNeuron force-pushed the 71-add-override-to-all-overriding-methods branch from 38dd0dc to 18ad457 Compare July 19, 2025 14:26
@FancyNeuron
Ensure @OverRide is added to every overriding method/property
a2aa2d3 
Add @OverRide decorators and test that enforces decorator on overriding methods/properties
@FancyNeuron FancyNeuron force-pushed the 71-add-override-to-all-overriding-methods branch from 18ad457 to a2aa2d3 Compare July 19, 2025 14:50
@FancyNeuron FancyNeuron merged commit 951ef32 into main Jul 19, 2025
3 checks passed
FancyNeuron added a commit that referenced this pull request Jul 19, 2025
@FancyNeuron
Ensure @OverRide is added to every overriding method/property (#74)
e5c4684 
Add @OverRide decorators and make mypy check for missing override decorators
FancyNeuron added a commit that referenced this pull request Jul 22, 2025
@FancyNeuron
Ensure @OverRide is added to every overriding method/property (#74)
8eaa180 
Add @OverRide decorators and make mypy check for missing override decorators
FancyNeuron added a commit that referenced this pull request Jul 22, 2025
@FancyNeuron
75 make mypy run in strict mode (#76)
e43a9c0 
* Ensure @OverRide is added to every overriding method/property (#74)

Add @OverRide decorators and make mypy check for missing override decorators

* Make mypy run in strict mode, fix violating mypy errors
@FancyNeuron FancyNeuron deleted the 71-add-override-to-all-overriding-methods branch July 22, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add @override to all overriding methods

2 participants

@FancyNeuron