feat(wip): change Logos-open-url to send messages over dbus#451
Draft
ctrlaltf24 wants to merge 4 commits intoFaithLife-Community:mainfrom
Draft
feat(wip): change Logos-open-url to send messages over dbus#451ctrlaltf24 wants to merge 4 commits intoFaithLife-Community:mainfrom
ctrlaltf24 wants to merge 4 commits intoFaithLife-Community:mainfrom
Conversation
Not sure why this didn't pop up earlier in testing, but for some reason it appeared on my machine so added an additional check to make sure the appimage downloads
Created a tiny rust binary to send messages over dbus, then implemented a dbus server in python Still need to package and extract the binary and double check dbus naming conventions to make sure the naming makes sense- much easier to change before we release anything Also refactored startup to initialize the python object then call start to enable being able to use the app instance in the dbus code. Testing still needed as of time of writing: - snap/flatpak - gui/tui exit conditions, need to make sure bases are covered after refactor - launching OD multiple times - opening link in the browser before OD starts - can we configure our .desktop files to open automatically? - consider a --daemon cli option in case someone just wants to run the dbus server in the background so they can open Logos urls all the time. Perhaps we can do this later - not very important, they can always have Logos open first before they hit the link (we can wait until it's a requested feature) Tested: - install and run using chromium - works.
thw26
reviewed
Oct 14, 2025
Collaborator
thw26
left a comment
thw26
left a comment
There was a problem hiding this comment.
Did an initial code review. Still needs tested.
| self.app = app | ||
|
|
||
| @method() | ||
| def Launch(self, args: 'as') -> None: # type: ignore[valid-type] |
Collaborator
There was a problem hiding this comment.
nit: comment should have two preceding spaces
Tested: - built binary - run uninstall, then install from binary - ran logos from binary - logged in using the browser - observed Logos application logged in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a tiny rust binary to send messages over dbus, then implemented a dbus server in python
Also refactored startup to initialize the python object then call start to enable being able to use the app instance in the dbus code.
TODO:
Tested: