Make %context exec-dir inherited by further includes. #218#219
Open
chen-factual wants to merge 1 commit intodevelopfrom
Open
Make %context exec-dir inherited by further includes. #218#219chen-factual wants to merge 1 commit intodevelopfrom
chen-factual wants to merge 1 commit intodevelopfrom
Conversation
|
Works for me! Thanks @chen-factual |
|
@chen-factual I think I spoke too soon. I think you somehow fixed the path that drake uses for subsequent Here is a repo I made to test context. You should be able to run drake from either the top level or from the director Thanks in advance for your help with this! The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #218. Ensures
%includes in%context-ed scripts also inherit the context.Example inclusion chain:
a.dcontextb.dincludec.d contextd.d`.The intended behavior is for
b.dto use its own exec-dir,c.dto use the exec-dir ofb.d, andd.dto use it's own exec-dir.cc @potash if you can pull this branch and double check on your setup I'd be appreciative.