Introduce MappingCollection interfaces as modifiable views of a tree's internal mapping store#133
Open
NebelNidas wants to merge 7 commits intoFabricMC:devfrom
Open
Introduce MappingCollection interfaces as modifiable views of a tree's internal mapping store#133NebelNidas wants to merge 7 commits intoFabricMC:devfrom
MappingCollection interfaces as modifiable views of a tree's internal mapping store#133NebelNidas wants to merge 7 commits intoFabricMC:devfrom
Conversation
…e's internal mapping store
Juuxel
reviewed
Apr 12, 2025
src/main/java/net/fabricmc/mappingio/tree/MappingCollectionView.java
Outdated
Show resolved
Hide resolved
modmuss50
reviewed
Apr 13, 2025
Member
modmuss50
left a comment
modmuss50
left a comment
There was a problem hiding this comment.
I think this is fine, id like to get @sfPlayer1 's input on this as well as its quite a large change.
modmuss50
approved these changes
Apr 13, 2025
NebelNidas
commented
Jul 19, 2025
| @Override | ||
| public boolean remove(Object o) { | ||
| assertModifiable(); | ||
| return backing.remove(o); |
Member
Author
There was a problem hiding this comment.
Needs to be handled by the tree instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains some Generics fuckery, mostly due to the inability to represent
V extends ElementMappingView super E. This is required since the collection holds elements of typeE, but allows elements of typeVto be added or queried via the*Compatiblemethods. Thankfully the API doesn't need to expose any of these internal shenanigans.A byproduct of the PR's changes is that mapping trees'
addmethods now also accept read-only mapping element views, the code for converting such arguments to the tree's internal representation was already in place; this doesn't change the API semantics.I also moved the
getKindmethods fromMemoryMappingTree's internal mapping entry implementations directly toElementMappingViewand added default implementations for them, used for some minor optimizations in the mapping collections.Supersedes #129.