Skip writing elements with no destination names where applicable#111
Merged
NebelNidas merged 10 commits intoFabricMC:devfrom Aug 31, 2024
Merged
Conversation
Also adds a task for regenerating some test mapping files and makes the migration map writer's output prettier.
modmuss50
requested changes
Aug 30, 2024
NebelNidas
commented
Aug 30, 2024
src/main/java/net/fabricmc/mappingio/format/intellij/MigrationMapConstants.java
Outdated
Show resolved
Hide resolved
Member
Author
|
The PR was suffering from some feature creep, I undid all the related changes and will submit a separate PR later |
modmuss50
approved these changes
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior is now consistent across all writers. If these elements should not be skipped, a
MappingNsCompleterhas to be used.Also adds a task for regenerating some test mapping files and makes the migration map writer's output prettier.