Merged
Conversation
FabienPapet
force-pushed
the
feat/volume-management
branch
from
53a4434 to
4ac5bb9
Compare
Closed
Add `volumes` and `volumeMounts` values to inject arbitrary Kubernetes volumes (Secrets, ConfigMaps, PVCs, etc.) into all workloads: deployment, workers, crons, and jobs. - charts/frankenphp/values.yaml: add volumes/volumeMounts with commented Symfony decrypt key example - templates/deployment.yaml: render extra volumeMounts and volumes - templates/worker.yaml: render extra volumeMounts and volumes alongside existing php.ini mount - templates/jobs.yaml: same as worker - templates/crons.yaml: add volumeMounts and volumes support - charts/frankenphp/values.schema.json: add schema for volumes/volumeMounts - README.md: document Volume Management with step-by-step instructions - examples/11-secrets-volumes.yaml: Symfony decrypt key example Secrets must be created externally before chart installation; the chart does not manage secret creation to keep sensitive data out of Helm history.
FabienPapet
force-pushed
the
feat/volume-management
branch
from
4ac5bb9 to
a797b10
Compare
- tests/volumes_test.yaml: 9 tests covering deployment, worker, cron, job - extra volumes/volumeMounts are rendered in all workload templates - extra mounts are appended after php-ini when both are set - volumes section is omitted when nothing is configured - Fix deployment.yaml: make volumeMounts and volumes sections conditional to avoid empty keys in the rendered manifest
FabienPapet
force-pushed
the
feat/volume-management
branch
from
a797b10 to
6bcdb84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.