Configure global context to manage runtime configuration #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refact: implement logger functions that can be call directly
* feat: install platformdirs library to be able to fetch system directory as application directory or user directory that depends of the OS (linux, windows, ...)
* feat: implement ctx module to manage global context
FabienArcellier
commented
Jun 24, 2023
Pipfile
Outdated
| fixtup = {path = ".", editable=true} | ||
| six = "*" | ||
|
|
||
| platformdirs = "*" |
Owner
Author
There was a problem hiding this comment.
move platformdirs into setup.cfg dependency
FabienArcellier
commented
Jun 24, 2023
src/fixtup/entity/fixtup.py
Outdated
| enable_hooks: bool = True | ||
| enable_plugins: bool = True | ||
|
|
||
| # A chaque fois que fixtup.up est invoqué, fixtup redémarre comme si c'était une nouvelle exécution des |
Owner
Author
There was a problem hiding this comment.
translate this comment into english and delete line breaks
FabienArcellier
force-pushed
the
configure-global-context-to-manage-runtime-configuration
branch
2 times, most recently
from
9c38273 to
39ba127
Compare
* feat: implement ctx module to manage global context * feat: remove factory module (not used anymore) * feat: use global context in tests
FabienArcellier
force-pushed
the
configure-global-context-to-manage-runtime-configuration
branch
from
39ba127 to
b9b0775
Compare
* improve code after review
FabienArcellier
commented
Jun 24, 2023
src/fixtup/entity/fixtup.py
Outdated
| class Fixtup: | ||
|
|
||
| # Global settings | ||
| appname: str = 'fixtup' |
Owner
Author
There was a problem hiding this comment.
I should use attr syntax for the attributes (here it's dataclass syntax)
appname = attr.ib(default='fixtup')
* feat: use context instead of read_settings
FabienArcellier
force-pushed
the
configure-global-context-to-manage-runtime-configuration
branch
from
5a2ec80 to
220b95b
Compare
* refact: rename functions
* feat: use simple implementation * feat: attach fixture engine to fixtup context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.