led code

[abi-appusamy9932]

LedIO + CANdle and Sim implementations

LedStrip for high level control

[Luddo183]

Overall, the logic and control is good. There's a few implementation things that need to be tweaked, and the code needs to rewritten to use the latest Phoenix6 API. Start by deleting the Phoenix5 vendordep, and see what you need to rewrite from there.

[Luddo183]

Add a function to set the entire strip (all it needs to do is call setFirst and setSecond, but a single function to do both would be nice)

[Luddo183]

Avoid using the Phoenix specific Animation type in the generic IO. You could make a custom class that extends Animation, or a class that can convert itself to a Phoenix Animation (eg. PIDFFConfigs).

[Luddo183]

Remember integers aren't always perfectly divisible by 2

[Luddo183]

Not sure how hard it would be to implement, but it would be possible to also animate halves (eg. top half is the rainbow animation, bottom is the fire animation)? Not necessary though.

[Luddo183]

Avoid using driver/operator naming, stick to the first/second naming.

[Luddo183]

The comments on the class are nice, but don't explain the functions in the class doc. Just a high-level explanation of what the class does.

[Luddo183]

If you are using a periodic() function, would it useful to have the class extend SubsystemBase so the periodic function gets called automatically? It would also let you use commands to set the LEDs, and let the CommandScheduler handle conflicts.

[Luddo183]

The default state for the LEDs should always be off, and not flashing white.

[Luddo183]

Isn't there a better way to do flashing? If you already using animations, why not create a flashing animation?

[Luddo183]

Going forward, avoid changing stuff in other files not related to the task at hand. These are just comments, so I'll leave them, but if you want to edit something else, make another branch.

[Luddo183]

Phoenix5 is no longer necessary, Phoenix6 now includes the CANdle stuff.