Open
Conversation
- Use argparse to interpret command-line arguments - Change output file and folder structure - Require Python 3 - Add requirements.txt - Add parameter for palette file to use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rewrote the import and export scripts. They're now more simple and take advantage of a few libraries to streamline e.g. command-line argument parsing.
There are backwards-incompatible changes that may make you not want to merge this PR. The scripts require Python 3 now (probably, I haven't tested them with Python 2). The folder and file structure has also changed. I think the new structure makes things more flexible - instead of requiring a very specific file naming convention, files are simply imported according to their alphanumeric order, so you can use whatever file names you want for your sprites.
Instead of storing hotspot, coldspot, etc in the file names, each animation now has a single
.settingsfile that defines these properties for all frames as a yaml file. This has the advantage, for sprites that share a common origin or coldspot across multiple frames, of being able to define one 'default' set of properties. This can be overridden on a per-frame basis, and changing them is now done by editing a single file instead of having to rename each individual frame's file.I like this better and think it's more flexible. But YMMV and, as said, it breaks backwards compatibility. So I understand if you prefer the old way of doing things, in which case I'll just maintain my own fork.