Skip to content

Fix: Pass proxy to download requests #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
McIgor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Pass proxy to download requests #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function calcPercents(current, max) {
return ((current / max) * 100).toFixed(1);
}

export default async function downloadFile(url, outputPath, subtask, videoId) {
export default async function downloadFile(url, outputPath, subtask, videoId, proxyData) {
if (!url) {
throw new Error("Invalid download link");
}
Expand All @@ -17,6 +17,7 @@ export default async function downloadFile(url, outputPath, subtask, videoId) {
method: "get",
url: url,
responseType: "stream",
proxy: proxyData || false,
});

const totalLength = headers["content-length"];
Expand Down
2 changes: 2 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ async function main() {
`${OUTPUT_DIR}/${filename}`,
subtask,
`(ID: ${videoId} as ${filename})`,
proxyData,
)
.then(() => {
subtask.title = `Download ${taskSubTitle} completed!`;
Expand Down Expand Up @@ -411,6 +412,7 @@ async function main() {
`${OUTPUT_DIR}/${filename}`,
subtask,
`(ID: ${videoId} as ${filename})`,
proxyData,
)
.then(() => {
subtask.title = `Download ${taskSubTitle} completed!`;
Expand Down