Fix modal handling on quiz completion and isActive logic#161
Merged
Fix modal handling on quiz completion and isActive logic#161
Conversation
ProctorMonitor now closes the identity modal when the quiz is finished or inactive. Updated QuizContent to improve isActive logic, ensuring the proctoring monitor is only active when appropriate.
Previously, the AI explanation button was only shown if the quiz was passed. This change makes the button always visible, allowing users to access AI explanations regardless of their quiz result.
hofang42
added a commit
that referenced
this pull request
Nov 18, 2025
* [FLN-133][Hoang][UI] Update UI for add course [07.10.2025] (#110) * [FLN-134][Duc][UI] Apply API for Adding Course [15.10.2025] (#111) * [FLN-136][Hoang][UI] Add UI for instructor [15.10.2025] (#112) * [FLN-143][Duc][UI] Apply Quiz API to WatchCourse [17.10.2025] (#113) * [FLN-144] instructor registration (#114) * [Dat] Add UI for Instructor registration #16.10.2025 * [Dat] Add UI for Registration Instructor #17.10.2025 * Delete package-lock.json * Update GeminiChatBox.jsx * Update authService.js * [Fix] Remove biography & bank from instructor profile (#115) * Remove bio field from instructor registration Eliminated the 'bio' field from the instructor registration form, validation, and submission payload. This streamlines the registration process by no longer requiring instructors to provide a bio. * Remove payment information fields from instructor registration Eliminated bank name, account number, and account holder name fields from the instructor registration form and related validation logic. This streamlines the registration process by no longer requiring payment information at this stage. * Move auth routes outside main layout in router Auth routes are now rendered outside the AppLayout component, ensuring they do not inherit the main layout. This change improves route structure and separation between authentication and main application pages. * Refactor auth routes into with/without layout groups (#116) Split authentication routes into two groups: routes with layout (login, signup, forgot/reset password) and routes without layout (verification and confirmation pages). Updated the main router to use these new route groups for clearer structure and maintainability, while preserving backward compatibility. * [FLN-148][Hoang][UI] Add function verify instructor [19.10.2025] (#117) * [FLN][Duc][UI] Reapply APIs for instructor [18.10.2025] (#118) * [FLN-130][Thien][UI] Implement PayOs payment code [18.10.2025] (#119) * Add after payment logic and something else (#120) * [FLN-130][Thien][UI] Implement PayOs payment code [18.10.2025] * [FLN-130][Thien][UI] Add logic after payment [19.10.2025] * [FLN-156][Dat][FE] Instructor Profile Edit Page [19.10.2025] (#122) * [FLN-157][Dat][FE] Instructor Public Profile Page with Figma Design [19.10.2025] (#123) * [FLN-158][Dat][FE] Instructor Info Card on Course Details [19.10.2025] (#124) * [FLN-159][Dat][FE] Routing and Navigation with API Integration [19.10.2025] (#125) * [FLN-160][Dat][FE] Admin Censor Instructor and UI Polish [19.10.2025] (#126) * [FLN-162][Thien][UI] Send welcome message when user enrolled an course [19.10.2025] (#127) * [FLN-163][UI] Update Instructor Rating Display on Course Details Page [19.10.2025] (#128) * [FLN-161][Hoang][UI] Add censor course for admin [19.10.2025] (#129) * [FLN-152][UI] Apply Discount API for Instructor (#121) * [FLN-152][Duc][UI] Apply Discount API for Instructor [19.10.2025] * [FLN-152][Duc][UI] Apply Discount API to Checkout [19.10.2025] * [FLN-164][Thien][UI] Fix view top categories [19.10.2025] (#131) * [FLN-165][Duc][UI] Add Quiz Template, Fix API [19.10.2025] (#132) * [FLN-166][FLN-167][FE] Instructor Register Button & Active Course Filter [20.10.2025] (#133) * [FLN-166][FLN-167][FE] Instructor Register Button & Active Course Filter [20.10.2025] * Enhance course author display and update dashboard stats Updated BestSellingCourse and RecentlyAddedCourse components to dynamically display the instructor's name and avatar based on course data, defaulting to generic values if missing. Modified InstructorDashboard to show total revenue in VND format. Added route titles for 'Profile' and 'Discounts' in InstructorLayout for improved navigation. * [FLN-129][Hoang][UI] Add modal for AI explain [25.10.2025] (#135) * [FLN-129][Hoang][UI] Add modal for AI explain [25.10.2025] * [FLN-129][Hoang][BE] Cập nhật thêm logic [25.10.2025] * [FLN-172][Duc][UI] Update Upload Quiz for Instructor [30.10.2025] (#136) * [FLN-171][Duc][UI] Add AI summaries Video&Article [30.10.2025] (#137) * [FLN-176][Hoang][UI] Tạo Learning Path cho học viên bằng AI [11.01.2025] (#138) * [FLN-170][Thien][UI] Auto creating cerficate [01.11.2025] (#139) * [UI][fix] real-time fetch certificate (#140) * [FLN-177][Thien][UI] Fix bug real-time receiving certificate [02.11.2025] * [FLN-177][Thien][UI] Add animation congratulation [02.11.2025] * [FLN-178][Thien][UI] Fix categories label icon and text size card [02.11.2025] (#141) * [FLN-179][Thien][UI] Sync data in course detail page [02.11.2025] (#142) * [FLN-180][Duc][Bug] Fix quiz result saving [02.11.2025] (#143) * [FLN-181][Hoang][UI] Update instructor dashboard [02.11.2025] (#144) * [FLN-183][Thien][UI] Hide search bar in some screen avoid duplicate [02.11.2025] (#145) * [FLN-185][Duc][UI] Sửa bug không fetch đúng data ở nhiều màn [02.11.2025] (#146) * [FLN-174][UI] ai quiz generation (#148) * [FLN-174][Dat][UI] Add AI Quiz Generation Feature [30.10.2025] * feat: Add AI-powered proctoring system with face recognition and progressive punishment * [FLN-186][Duc][UI] Update Instructor my course chart [03.11.2025] (#150) * [FLN-175] [FE] Update ban/unban user (#151) * banned update * Add AI review status and score to instructor management Introduces display of AI review status badges and scores in the instructor applications table and details modal. Updates filtering logic to include AI-approved applications and provides visual cues for manual review, approval, and rejection statuses. * banned update (#152) * [FLN-188][Duc][UI] Thêm prefix css [03.11.2025] (#153) * [FLN-189][FE] Fix quiz proctoring system violations and face detection (#154) - Fixed premature quiz locking (was locking after 1-2 violations instead of 3) - Removed duplicate violation counting logic in QuizContent - Added identity verification on "Start Quiz" button click instead of intro page - Relaxed face detection: users can look away without getting locked - Added 3-second threshold warning when user looks away from camera - Fixed warning modal z-index to prevent header overlap - Added throttling (5 seconds) for face mismatch warnings to prevent spam - Removed "no face detected" warning banner from camera preview 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> * [FLN-190][Thien][API] Format Card detail attribute in Home Screen [03.11.2025] (#155) * FLN-191][Thien][UI] Enhance logic search bar and add to wishlist requirement [03.11.2025] (#157) * [FLN-192][Thien][UI] Add Withdraw function for instructor [03.11.2025] (#158) * [FLN-175] [FE] AI for instructor's application (#159) * banned update * Add AI review status and score to instructor management Introduces display of AI review status badges and scores in the instructor applications table and details modal. Updates filtering logic to include AI-approved applications and provides visual cues for manual review, approval, and rejection statuses. * feat: Add AI review status badge in CensorInstructor - Added 'Manual Approval' badge for AI-reviewed applications - Display indigo badge when approved but no AI review status exists - Enhanced UI for admin to identify AI-reviewed vs manual-reviewed applications * feat: Add instructor application verification page and routes - Create InstructorVerifyApplicationPage for existing users - Add verifyInstructorEmail and verifyInstructorApplication API functions - Update InstructorVerifyEmailPage to use correct API endpoint - Add route for /verify-instructor-application/:token --------- Co-authored-by: cheeseachocolate <giangnlde180815@fpt.edu.vn> * [UI] Sửa Face Verification chỉ hiện 1 lần (#160) * Fix modal handling on quiz completion and isActive logic (#161) * Fix modal handling on quiz completion and isActive logic ProctorMonitor now closes the identity modal when the quiz is finished or inactive. Updated QuizContent to improve isActive logic, ensuring the proctoring monitor is only active when appropriate. * Show AI explanation button for all quiz results Previously, the AI explanation button was only shown if the quiz was passed. This change makes the button always visible, allowing users to access AI explanations regardless of their quiz result. * Make quiz lockout user-specific in QuizContent (#162) Quiz lockout is now tracked per user by including userId in the localStorage key. This prevents lockouts from affecting all users on the same device and ensures proper isolation of quiz access restrictions. * [FLN-195][Thien][UI] Add UI for Notification function[18.11.2025] (#164) * [FLN-194][Hoang][UI] Fix chat and AI [17.11.2025] (#163) * [FLN-196][Duc][UI] Fix Student my course card, allow download summaries [18.11.2025] (#165) --------- Co-authored-by: Nguyen Doan Trong Duc <89635693+trongducdoan25@users.noreply.github.com> Co-authored-by: Nekomimi <kthkun@gmail.com> Co-authored-by: Huynh Dinh Thien <136036261+Nomsociuu@users.noreply.github.com> Co-authored-by: Nguyen Doan Trong Duc <89635693+justduck25@users.noreply.github.com> Co-authored-by: Nguyễn Lam Giang <133856538+gianglamnguyen@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: cheeseachocolate <giangnlde180815@fpt.edu.vn>
Nomsociuu
added a commit
that referenced
this pull request
Nov 18, 2025
* [FLN-133][Hoang][UI] Update UI for add course [07.10.2025] (#110) * [FLN-134][Duc][UI] Apply API for Adding Course [15.10.2025] (#111) * [FLN-136][Hoang][UI] Add UI for instructor [15.10.2025] (#112) * [FLN-143][Duc][UI] Apply Quiz API to WatchCourse [17.10.2025] (#113) * [FLN-144] instructor registration (#114) * [Dat] Add UI for Instructor registration #16.10.2025 * [Dat] Add UI for Registration Instructor #17.10.2025 * Delete package-lock.json * Update GeminiChatBox.jsx * Update authService.js * [Fix] Remove biography & bank from instructor profile (#115) * Remove bio field from instructor registration Eliminated the 'bio' field from the instructor registration form, validation, and submission payload. This streamlines the registration process by no longer requiring instructors to provide a bio. * Remove payment information fields from instructor registration Eliminated bank name, account number, and account holder name fields from the instructor registration form and related validation logic. This streamlines the registration process by no longer requiring payment information at this stage. * Move auth routes outside main layout in router Auth routes are now rendered outside the AppLayout component, ensuring they do not inherit the main layout. This change improves route structure and separation between authentication and main application pages. * Refactor auth routes into with/without layout groups (#116) Split authentication routes into two groups: routes with layout (login, signup, forgot/reset password) and routes without layout (verification and confirmation pages). Updated the main router to use these new route groups for clearer structure and maintainability, while preserving backward compatibility. * [FLN-148][Hoang][UI] Add function verify instructor [19.10.2025] (#117) * [FLN][Duc][UI] Reapply APIs for instructor [18.10.2025] (#118) * [FLN-130][Thien][UI] Implement PayOs payment code [18.10.2025] (#119) * Add after payment logic and something else (#120) * [FLN-130][Thien][UI] Implement PayOs payment code [18.10.2025] * [FLN-130][Thien][UI] Add logic after payment [19.10.2025] * [FLN-156][Dat][FE] Instructor Profile Edit Page [19.10.2025] (#122) * [FLN-157][Dat][FE] Instructor Public Profile Page with Figma Design [19.10.2025] (#123) * [FLN-158][Dat][FE] Instructor Info Card on Course Details [19.10.2025] (#124) * [FLN-159][Dat][FE] Routing and Navigation with API Integration [19.10.2025] (#125) * [FLN-160][Dat][FE] Admin Censor Instructor and UI Polish [19.10.2025] (#126) * [FLN-162][Thien][UI] Send welcome message when user enrolled an course [19.10.2025] (#127) * [FLN-163][UI] Update Instructor Rating Display on Course Details Page [19.10.2025] (#128) * [FLN-161][Hoang][UI] Add censor course for admin [19.10.2025] (#129) * [FLN-152][UI] Apply Discount API for Instructor (#121) * [FLN-152][Duc][UI] Apply Discount API for Instructor [19.10.2025] * [FLN-152][Duc][UI] Apply Discount API to Checkout [19.10.2025] * [FLN-164][Thien][UI] Fix view top categories [19.10.2025] (#131) * [FLN-165][Duc][UI] Add Quiz Template, Fix API [19.10.2025] (#132) * [FLN-166][FLN-167][FE] Instructor Register Button & Active Course Filter [20.10.2025] (#133) * [FLN-166][FLN-167][FE] Instructor Register Button & Active Course Filter [20.10.2025] * Enhance course author display and update dashboard stats Updated BestSellingCourse and RecentlyAddedCourse components to dynamically display the instructor's name and avatar based on course data, defaulting to generic values if missing. Modified InstructorDashboard to show total revenue in VND format. Added route titles for 'Profile' and 'Discounts' in InstructorLayout for improved navigation. * [FLN-129][Hoang][UI] Add modal for AI explain [25.10.2025] (#135) * [FLN-129][Hoang][UI] Add modal for AI explain [25.10.2025] * [FLN-129][Hoang][BE] Cập nhật thêm logic [25.10.2025] * [FLN-172][Duc][UI] Update Upload Quiz for Instructor [30.10.2025] (#136) * [FLN-171][Duc][UI] Add AI summaries Video&Article [30.10.2025] (#137) * [FLN-176][Hoang][UI] Tạo Learning Path cho học viên bằng AI [11.01.2025] (#138) * [FLN-170][Thien][UI] Auto creating cerficate [01.11.2025] (#139) * [UI][fix] real-time fetch certificate (#140) * [FLN-177][Thien][UI] Fix bug real-time receiving certificate [02.11.2025] * [FLN-177][Thien][UI] Add animation congratulation [02.11.2025] * [FLN-178][Thien][UI] Fix categories label icon and text size card [02.11.2025] (#141) * [FLN-179][Thien][UI] Sync data in course detail page [02.11.2025] (#142) * [FLN-180][Duc][Bug] Fix quiz result saving [02.11.2025] (#143) * [FLN-181][Hoang][UI] Update instructor dashboard [02.11.2025] (#144) * [FLN-183][Thien][UI] Hide search bar in some screen avoid duplicate [02.11.2025] (#145) * [FLN-185][Duc][UI] Sửa bug không fetch đúng data ở nhiều màn [02.11.2025] (#146) * [FLN-174][UI] ai quiz generation (#148) * [FLN-174][Dat][UI] Add AI Quiz Generation Feature [30.10.2025] * feat: Add AI-powered proctoring system with face recognition and progressive punishment * [FLN-186][Duc][UI] Update Instructor my course chart [03.11.2025] (#150) * [FLN-175] [FE] Update ban/unban user (#151) * banned update * Add AI review status and score to instructor management Introduces display of AI review status badges and scores in the instructor applications table and details modal. Updates filtering logic to include AI-approved applications and provides visual cues for manual review, approval, and rejection statuses. * banned update (#152) * [FLN-188][Duc][UI] Thêm prefix css [03.11.2025] (#153) * [FLN-189][FE] Fix quiz proctoring system violations and face detection (#154) - Fixed premature quiz locking (was locking after 1-2 violations instead of 3) - Removed duplicate violation counting logic in QuizContent - Added identity verification on "Start Quiz" button click instead of intro page - Relaxed face detection: users can look away without getting locked - Added 3-second threshold warning when user looks away from camera - Fixed warning modal z-index to prevent header overlap - Added throttling (5 seconds) for face mismatch warnings to prevent spam - Removed "no face detected" warning banner from camera preview 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com> * [FLN-190][Thien][API] Format Card detail attribute in Home Screen [03.11.2025] (#155) * FLN-191][Thien][UI] Enhance logic search bar and add to wishlist requirement [03.11.2025] (#157) * [FLN-192][Thien][UI] Add Withdraw function for instructor [03.11.2025] (#158) * [FLN-175] [FE] AI for instructor's application (#159) * banned update * Add AI review status and score to instructor management Introduces display of AI review status badges and scores in the instructor applications table and details modal. Updates filtering logic to include AI-approved applications and provides visual cues for manual review, approval, and rejection statuses. * feat: Add AI review status badge in CensorInstructor - Added 'Manual Approval' badge for AI-reviewed applications - Display indigo badge when approved but no AI review status exists - Enhanced UI for admin to identify AI-reviewed vs manual-reviewed applications * feat: Add instructor application verification page and routes - Create InstructorVerifyApplicationPage for existing users - Add verifyInstructorEmail and verifyInstructorApplication API functions - Update InstructorVerifyEmailPage to use correct API endpoint - Add route for /verify-instructor-application/:token --------- Co-authored-by: cheeseachocolate <giangnlde180815@fpt.edu.vn> * [UI] Sửa Face Verification chỉ hiện 1 lần (#160) * Fix modal handling on quiz completion and isActive logic (#161) * Fix modal handling on quiz completion and isActive logic ProctorMonitor now closes the identity modal when the quiz is finished or inactive. Updated QuizContent to improve isActive logic, ensuring the proctoring monitor is only active when appropriate. * Show AI explanation button for all quiz results Previously, the AI explanation button was only shown if the quiz was passed. This change makes the button always visible, allowing users to access AI explanations regardless of their quiz result. * Make quiz lockout user-specific in QuizContent (#162) Quiz lockout is now tracked per user by including userId in the localStorage key. This prevents lockouts from affecting all users on the same device and ensures proper isolation of quiz access restrictions. * [FLN-195][Thien][UI] Add UI for Notification function[18.11.2025] (#164) * [FLN-194][Hoang][UI] Fix chat and AI [17.11.2025] (#163) * [FLN-196][Duc][UI] Fix Student my course card, allow download summaries [18.11.2025] (#165) * [FLN-197][Thien][UI] AI check comment UI [18.11.2025] (#166) --------- Co-authored-by: Thanh Hoang <126055913+hofang42@users.noreply.github.com> Co-authored-by: Nguyen Doan Trong Duc <89635693+trongducdoan25@users.noreply.github.com> Co-authored-by: Nekomimi <kthkun@gmail.com> Co-authored-by: Nguyen Doan Trong Duc <89635693+justduck25@users.noreply.github.com> Co-authored-by: Nguyễn Lam Giang <133856538+gianglamnguyen@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: cheeseachocolate <giangnlde180815@fpt.edu.vn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProctorMonitor now closes the identity modal when the quiz is finished or inactive. Updated QuizContent to improve isActive logic, ensuring the proctoring monitor is only active when appropriate.