CORE-477 fix the resource-viewer #449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safydy-r
commented
Apr 25, 2023
| <resource-viewer-block | ||
| v-for="block in activeFlow?.blocks ?? []" | ||
| v-show="visibleBlocks.includes(block.uuid)" | ||
| v-show="visibleBlocks === null || visibleBlocks.includes(block.uuid)" |
Member
Author
There was a problem hiding this comment.
I'm proposing here to always display those block if the visibleBlocks is null, which would allow us to make a test on that edge case scenario.
RiverSongFox
approved these changes
Apr 25, 2023
bulatgab
approved these changes
Apr 28, 2023
Collaborator
bulatgab
left a comment
bulatgab
left a comment
There was a problem hiding this comment.
And we already had the default value for visibleBlocks set to null 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
If we try to enable the resource viewer on community version by adding
resourceVieweras part ofenabledFeatures, we got this error.It happens because by default we set
visibleBlocksas null but we callvisibleBlocks.includes(block.uuid)in a condition