Refactor Config Handling & Add Multichain Support #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a dedicated `config` package (`config/config.go`) to manage configuration. - Updated `.gitignore` to properly exclude `config/xchain_key.json`. - Refactored `config.json` structure to support multiple source chains (e.g., Ethereum, Polygon, Avalanche). - Updated CLI to require a `--chain` argument to specify the source blockchain. - Modified `xchain.go` to dynamically load source chain configuration based on `--chain`. - Updated `NewAggregator` and other functions to use `config.SourceChainConfig`. - Fixed logging issue in `processDealStatus` by using `%v` instead of `%s` for structured data. - Removed old hardcoded `Config` struct from `xchain.go` and replaced it with the `config` package. - Updated tests (`xchain_test.go`) to use the new config structure and support multiple chains. - Updated `go.mod` to include `github.com/stretchr/testify` and `github.com/filecoin-project/go-cbor-util` for improved testing and CBOR support. This refactor improves modularity, allowing seamless integration of multiple blockchains.
longfeiWan9
reviewed
Feb 11, 2025
Contributor
|
I only have one comment above. The rest looks great. @snissn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Refactor Config Handling & Add Multichain Support
closes #11
Description:
This PR introduces a dedicated
configpackage to improve configuration management and adds support for multiple source blockchains. The refactor makes it easier to integrate different blockchain networks (e.g., Ethereum, Polygon, Avalanche) with Filecoin.Key Changes:
Config Refactor:
config/config.gofor better modularity..gitignoreto properly excludeconfig/xchain_key.json.config.jsonto support multiple source chains under"sources", with a"destination"section for Filecoin.CLI Enhancements:
--chainargument to specify the source blockchain.daemon,offer,dealStatus) to load chain-specific settings dynamically.Code Improvements:
Configstruct fromxchain.goand replaced it withconfig.Config.NewAggregatorand other relevant functions to useconfig.SourceChainConfig.processDealStatusby using%vinstead of%sfor structured data.Testing & Dependencies:
xchain_test.goto use the new config structure and test chain selection.go.modto includegithub.com/stretchr/testifyandgithub.com/filecoin-project/go-cbor-utilfor improved testing and CBOR support.Why This Matters: