fftw.pc.in: Add THREADLIBS to Libs.private#52
Conversation
|
FFTW does not in itself depend upon pthreads, so you will have to make a case for this change to be accepted. Threads are a global property of the program, and attempts to hide them in a library don't work. For example, a user may have a single-threaded program and rely on fftw to use multiple cores internally. Conversely, another user may have already created a few threads and expect fftw to run sequentially. A third user may be using MPI processes for compatibility with whatever other software expects MPI. Historically, FFTW has taken this position:
It is probably too late to fight this battle, but pthreads have a cost that everybody is now paying whether they are using them or not. For example, at some point in the past, the linux C library added locks to all stdio calls, with the effect that all programs (including sequential ones) became slower. For example, getchar() is 3x slower than getchar_unlocked() (which is what getchar() used to be). We cannot fight this madness, but at least we are trying not to help it. |
antoniovazquezblanco
left a comment
There was a problem hiding this comment.
This pull request seems to have been sitting for long enough...
The right approach seems to have been described in #180:
- For each configuration, a new
fft..._threads.pcfile should be generated for each variant. - That new
.pcfile may include the threadslibs.privatedependency.
I believe that this PR can be closed and that the issue should be tracked via #180.
No description provided.