-
Notifications
You must be signed in to change notification settings - Fork 107
Add FFMS_GetTrackMetadata #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dwbuiten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like hyper-specific APIs like this, if I am honest.
IMO it should be a generic stream metadata API, not hardcoded to one single thing someone needed once.
|
Do you mean something like |
|
I mean something like a way to generically get metadata from a track, rather than solely |
|
Ok, in this case, I believe I could add Currently, the |
I think the function should be generic and allow you to get any ket, and not just specific ones. |
8148cf3 to
40726ae
Compare
FFMS_GetTrackMetadata simply exposes AVStream::metadata to users.
40726ae to
588daf4
Compare
|
Ok, I believe it should be fine like this. |
Add FFMS_GetTrackMetadata.
This is useful for tool like Aegisub that expose all the audio tracks to the user by exposing the track title
I tested this PR with this code
@arch1t3cht