Add LastEndPTS to FFMS_VideoProperties #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moi15moi
force-pushed
the
Add-First/Last/LastEnd-PTS
branch
from
58bed53 to
fb8b8d9
Compare
Member
|
I understand why LastEndPTS (confusing name...) can be used, but I don't know the point of including FirstPTS and LastPTS< which are trivially and cheaply available from FFMS_FrameInfo on the first and last frames, which you'll have access to at that point already. |
Contributor
Author
|
Its just that FirstTime, LastTime and LastEndTime exist, so I thought adding the same, but you are totally right |
Contributor
Author
|
If you want, i can remove FirstTime and LastTime. |
Contributor
Author
|
@dwbuiten Could you review the PR? |
Member
Yes, please. Sorry, this is a busy time of year for me. |
moi15moi
force-pushed
the
Add-First/Last/LastEnd-PTS
branch
from
fb8b8d9 to
9aa0364
Compare
Contributor
Author
|
Oups, I meant |
moi15moi
changed the title
moi15moi
force-pushed
the
Add-First/Last/LastEnd-PTS
branch
from
9aa0364 to
65afb86
Compare
Member
|
Still missing a version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ffms2 has FirstTime/LastTime/LastEndTime, but I personally need PTS to avoid any problem with double accuracy.
Also, from all the talk that have been done in discord, I assume that, in some weird case,
LastPTSmight be equal toLastEndPTS? If it is the case, please tell me and I will document it.