-
Notifications
You must be signed in to change notification settings - Fork 68
Add yac interface to couple to ICON #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dsidoren @sveta-loza Can we sort out what needs to be done for merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, the checks are failing:
https://github.com/FESOM/fesom2/actions/runs/13158564989/job/36721281053?pr=683#step:6:915
/__w/fesom2/fesom2/src/gen_forcing_couple.F90:276:9:
276 | end do
| 1
Error: Expecting END SUBROUTINE statement at (1)After that goes through I'll give this branch a try as coupled to openifs through oasis. Then someone also needs to test coupled to echam through oasis. @christian-stepanek maybe?
…rary (ifsinterface)
there was no need to change sign in evaporation here (Sveta)
removed unnecessary YAC directives (Sveta)
|
I got around to testing this branch as part of AWI-CM3 (meaning oasis true, yac false). I get a compile time error: Full logfile attached. |
|
Any update on this? |
|
superseeded by #776 |
This PR adds yac as a coupling library to FESOM, such that it can be coupled to ICON.