Skip to content

Conversation

@nils3er
Copy link
Collaborator

@nils3er nils3er commented Feb 5, 2025

This PR adds yac as a coupling library to FESOM, such that it can be coupled to ICON.

@nils3er
Copy link
Collaborator Author

nils3er commented Feb 5, 2025

@dsidoren @sveta-loza Can we sort out what needs to be done for merging this.
Especially the build system is a bit convoluted. Maybe @JanStreffing can help to streamline the changes with the existing coupling stuff?

Copy link
Collaborator

@JanStreffing JanStreffing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, the checks are failing:
https://github.com/FESOM/fesom2/actions/runs/13158564989/job/36721281053?pr=683#step:6:915

 /__w/fesom2/fesom2/src/gen_forcing_couple.F90:276:9:

  276 |       end do
      |         1
Error: Expecting END SUBROUTINE statement at (1)

After that goes through I'll give this branch a try as coupled to openifs through oasis. Then someone also needs to test coupled to echam through oasis. @christian-stepanek maybe?

@JanStreffing
Copy link
Collaborator

I got around to testing this branch as part of AWI-CM3 (meaning oasis true, yac false). I get a compile time error:

/work/ab0246/a270092/model_codes/awicm3-v3.4/fesom-2.6/src/io_restart.F90:195:90:

  195 |   call ice_files%def_node_var_optional('ice_albedo', 'ice albedo',    '-',   ice%atmcoupl%ice_alb, mesh, partit)
      |                                                                                          1
Error: 'atmcoupl' at (1) is not a member of the 't_ice' structure

Full logfile attached.
comp.log

@JanStreffing
Copy link
Collaborator

Any update on this?
There seems to be interest in the community to use this interface.

@JanStreffing JanStreffing added this to the FESOM 2.7 milestone Aug 19, 2025
@JanStreffing JanStreffing marked this pull request as ready for review September 8, 2025 10:19
@nils3er
Copy link
Collaborator Author

nils3er commented Oct 1, 2025

superseeded by #776

@nils3er nils3er closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants