Open
Conversation
Owner
|
Hi Martyn, Thanks a lot for the update and fixes (also for the other packages). I'm looking forward to see JAGS 5.0 released and I will update the package on CRAN accordingly then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the forthcoming release of JAGS 5.0.0 I am testing CRAN packages to see if they work with the new version. Since RoBMA uses the C++ API it needs to be patched to work with JAGS 5.0.0
The main changes to the JAGS API are:
Changes make the patched version dependent on JAGS 5.0.0 and above.
You have a quick CRAN test that captures the output from some short MCMC runs. This test is fragile as we cannot guarantee reproducibility at this level between versions. If you want to keep the test then you will need to recapture new output using JAGS 5.0.0. However, I recommend that you wait until the release as other changes may take place as I work through other CRAN packages.