Make db-type and db-version required for maven-verify workflow #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisvang
force-pushed
the
fix/issue39-postgres-version
branch
from
fb05d30 to
ec19fc1
Compare
dennisvang
force-pushed
the
fix/issue39-postgres-version
branch
from
ec19fc1 to
af5c453
Compare
dennisvang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from #40 expect a
db-version, but it is complicated to handle a default value for mongo and postgres together.Unfortunately Github actions cannot fall back on the action's default if the reusable workflow specifies the parameter.
We could specify default versions for both mongo and postgres, but then we need to maintain those hard-coded versions.
Therefore, the best option is to make the
db-versionrequired.While we're at it, better make the
db-typerequired as well, otherwise it makes no sense.Note that we can still skip all db setup by specifying a non-existent
db-type(e.g. empty string)