Issue/#1015 Fix pop timer rate calculation #1065
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1015 which notes that the queue pop timer rate is calculated incorrectly.
Fixed by finding the number of new players who have joined the queue - turned out to be pretty simple thanks to some existing logic.
Unit tests:
pipenv run tests tests/unit_tests -k poppipenv run tests tests/unit_testsCloses #1015
Some notes on the consequences of this change: