Skip to content

Import excel sheet to add student to activity table #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FidaaHersh wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Import excel sheet to add student to activity table #88

FidaaHersh wants to merge 12 commits into from

Conversation

@FidaaHersh
Copy link
Contributor

@FidaaHersh FidaaHersh commented Feb 21, 2019 •
edited
Loading

  • import data from CSV sheet.

  • connect imported data with backend.

  • add data to DB.

@FidaaHersh FidaaHersh added the help wanted Extra attention is needed label Feb 24, 2019
@FidaaHersh FidaaHersh added done awaiting-review and removed help wanted Extra attention is needed labels Feb 24, 2019
@FidaaHersh FidaaHersh changed the title WIP: Import excel sheet to add student to activity table Import excel sheet to add student to activity table Feb 24, 2019
@FidaaHersh FidaaHersh requested review from m4v15 and removed request for jema28 February 24, 2019 11:47
@jema28
Copy link
Contributor

jema28 commented Feb 24, 2019 •
edited
Loading

  1. There needs to be an import label as it's unclear what you're choosing the file for.
  2. There is so message that the fields have been added. When does this happen?
  3. Please fix merge conflicts.

jema28
jema28 suggested changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@jema28 jema28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my initial comments. Also, the date format needs to be checked as it's currently not compatible.

@FidaaHersh FidaaHersh temporarily deployed to m-a-platform February 25, 2019 08:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhmdtshref mhmdtshref Awaiting requested review from mhmdtshref

@amanshawar amanshawar Awaiting requested review from amanshawar

@RazanTayyem RazanTayyem Awaiting requested review from RazanTayyem

@m4v15 m4v15 Awaiting requested review from m4v15

1 more reviewer

@jema28 jema28 jema28 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jema28 jema28

Labels

awaiting-review done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FidaaHersh @jema28