Fixes for from PR #18 + credentials directory #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: With the current Chart RBAC resource names are hard coded and not optional so it's impossible to deploy more than one instance in a namespace Solution: This uses the helper f5-bigip-ctlr.fullname as the name of each resource to it's unique. It also add variables to make the RBAc resources optional. You can also set the name of the service account to use so you can use it across all deploys. Testing (optional if not described in Solution section): Description of tests that were run to exercise the solutions (unit tests, system tests, etc)
Fix name of ClusterRole in ClusterRoleBinding
|
@kavitha-f5 @f5tsomanchi dev can you please review and approve @chen23 commits. TY |
|
@chen23 @rendhalver - Fixes from PR#18, require CLA to be signed. Please find the CLA document at https://clouddocs.f5.com/containers/v2/cla_landing.html. Please submit/email a signed copy of the same to ContainerConnector_CLA@f5.com to consider the fix. Please include your github handle in the CLA email. |
|
@chen23 - Can you please separate your fix for PR#18. @rendhalver fix requires CLA be signed and also need to attach that CLA in this conversation and I feel it may take time. |
Contributor
Author
|
per your request I have created a separate PR #25 |
Contributor
|
Closing this PR, since changes have been integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #18
Also updates “stable” template
Adds “credentials directory” for secrets (new default)