Better External DB Provider Support#18
Open
sprocktech-dev wants to merge 21 commits intoF3-Nation:mainfrom
Open
Better External DB Provider Support#18sprocktech-dev wants to merge 21 commits intoF3-Nation:mainfrom
sprocktech-dev wants to merge 21 commits intoF3-Nation:mainfrom
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Adjusted app DB user creation to better accomodate other DB providers like TiDB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes some code updates related to previous dependabot PRs. However, most of the PR is related to getting the app to connect to a TiDB external database provider on their free tier. It also includes slight performance tweaks for AWS Lambda cold starts.
Added
ExistingDatabasePort,ExistingDatabaseCreateAppUser,ExistingDatabaseCreateSchema,ExistingDatabaseUsernamePrefix,ExistingDatabaseAppUsername(AWS) / GCP equivalents — support TiDB Cloud and other managed DB providers with cluster-prefixed usernames and 32-char limitsChanged
sbadmin_{stage}(wassyncbot_admin_{stage}),sbapp_{stage}(wassyncbot_user_{stage}). Existing RDS instances keep their original master username.actions/checkoutv6,actions/setup-pythonv6,actions/upload-artifactv7,actions/download-artifactv8,aws-actions/configure-aws-credentialsv6pythonimage (keeps base image on Python 3.12.x line)lambda:InvokeFunction-- re-run the deploy script (Bootstrap task) oraws cloudformation deploythe bootstrap stack to pick up this permissionFixed
datetime.utcnow()withdatetime.now(UTC)in backup/migration export helpersHow to test
Use the
EXISTING_DATABASE_*env vars to setup a connection to an external database provider.Checklist
syncbot/(keep infra ininfra/and workflows)