Skip to content

Page title updates and PAX FNG date display fix#95

Merged
f3-jolt merged 7 commits intostagingfrom
charts
Mar 24, 2026
Merged

Page title updates and PAX FNG date display fix#95
f3-jolt merged 7 commits intostagingfrom
charts

Conversation

@f3-jolt
Copy link
Copy Markdown
Collaborator

@f3-jolt f3-jolt commented Mar 24, 2026

👋 TL;DR

Updated page title updates to remove the double BQ calls and FNG date logic.

🔎 Details

  • Replace server-side generateMetadata with a client-side document.title update in PageHeader, eliminating an extra unauthenticated BQ query per page load on AO, PAX, and Region stat pages [resolved issue Take a look at double queries #93]
  • Fix PAX Summary Card to fall back to first_event_date when fng_date is null [resolves issue Start date override on PAX page #86]
  • Remove stale generateMetadata test files (tested functionality that no longer exists)

Changes

  • src/components/pageHeader.tsx — adds useEffect to set document.title = name + " | PAX Vault" on mount
  • src/app/stats/ao/[aoId]/page.tsx, pax/[paxId]/page.tsx, region/[regionId]/page.tsx — removes generateMetadata export
  • src/components/pax/SummaryCard.tsx — shows first_event_date as fallback when fng_date is null
  • src/app/stats/*/page.test.ts — removed (tested removed functionality)

✅ How to Test

  • Navigate to /stats/region/[id], /stats/ao/[id], /stats/pax/[id] — confirm browser tab title shows <Name> | PAX Vault after hydration
  • Visit a PAX page where FNG date is null — confirm First Event date displays instead

🥜 GIF

lack-of-hustle

taterhead247 and others added 7 commits March 10, 2026 06:52
* Multiple issue fix (#80)

* Fix Issue # 71

* Fix Issue # 71

* Complete Issue #69

* Resolve Issue #75

* Resolves Issue #76

---------

Co-authored-by: Jay Stobie <j.stobie@Jays-MacBook-Pro.local>

* Remove @jstobie-quadient from CODEOWNERS

---------

Co-authored-by: Jay Stobie <78213290+f3-jolt@users.noreply.github.com>
Co-authored-by: Jay Stobie <j.stobie@Jays-MacBook-Pro.local>
@f3-jolt f3-jolt merged commit f27874a into staging Mar 24, 2026
6 checks passed
@f3-jolt f3-jolt deleted the charts branch March 24, 2026 21:11
f3-jolt added a commit that referenced this pull request Mar 24, 2026
* Fix multiple issues including #69, #71, #75, and #76 (#81)

* Multiple issue fix (#80)

* Fix Issue # 71

* Fix Issue # 71

* Complete Issue #69

* Resolve Issue #75

* Resolves Issue #76

---------



* Remove @jstobie-quadient from CODEOWNERS

---------




* Initial Chart Load

* resolves issue #93

* hide charts for now

* resolved issue #86

* hiding charts but keeping in the background

---------

Co-authored-by: Damon Vinciguerra <damon.vinciguerra@gmail.com>
Co-authored-by: Jay Stobie <j.stobie@Jays-MacBook-Pro.local>
This was linked to issues Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Take a look at double queries Start date override on PAX page

2 participants