Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
AchievementsCardto region pages showing PAX approaching post/Q milestones and upcoming FNG anniversaries within 14 daysRegionAchievementPaxtype and a BigQuery CTE pipeline ingetPageDatathat computes next milestones (25/50/100/200/.../1000) for both region and nation scope, and anniversary dates using leap-year-safeDATE_ADDlogicRegionalPageWrapper; layout rearranged so Achievements sits beside the Kotters + Upcoming columnWhat changed
src/lib/types.ts— newRegionAchievementPaxinterface;RegionDataextended withachievementssrc/lib/bq/regions.ts— newachievement_*CTEs appended togetPageData; achievements column added toSELECTand return valuesrc/components/region/AchievementsCard.tsx— new client component with Region/Nation scope toggle and All/Posts/Qs/Anniversaries filter; sorted by urgency (days/count remaining)src/components/region/PageWrapper.tsx— imports and rendersAchievementsCard; Kotters + Upcoming events stacked in a nested column alongside itsrc/app/stats/region/[regionId]/loader.tsandpage.tsx— passachievementsthrough the data pipelineTest plan