Fix bugs in roles API, avatar state, toast a11y, meta serialization, and session expiry test#164
Merged
taterhead247 merged 2 commits intofeat/mefrom Mar 5, 2026
Merged
Conversation
Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Set up initial configuration for profile manager app
Fix bugs in roles API, avatar state, toast a11y, meta serialization, and session expiry test
Mar 5, 2026
taterhead247
added a commit
that referenced
this pull request
Mar 6, 2026
…and session expiry test (#164) * Initial plan * Fix all remaining open PR review comments Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com>
pstaylor-patrick
pushed a commit
that referenced
this pull request
Apr 9, 2026
…and session expiry test (#164) * Initial plan * Fix all remaining open PR review comments Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com>
pstaylor-patrick
pushed a commit
that referenced
this pull request
Apr 9, 2026
…and session expiry test (#164) * Initial plan * Fix all remaining open PR review comments Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five correctness/quality issues identified in PR review across
apps/me.Changes
roles/route.ts: StriporgName(and any extra fields) from roles before callingupdateUser()by mapping to{ orgId, roleName }— matches the same pattern used elsewhere and avoids upstream schema rejection.avatar.tsx: ResetimgErrorviauseEffectonsrcchanges so a new valid URL isn't permanently shadowed by a prior load failure.toast.tsx: Addtype="button"andaria-label="Dismiss"to the close button — prevents accidental form submits and enables screen reader announcements.profile/route.ts: SerializemergedMetawithJSON.stringify()before assigning toupdateBody.meta, matchingUserUpsert.meta: stringcontract.session.test.ts: Replace the non-functional expired-session test with a real one usingvi.useFakeTimers()— advances time pastSESSION_COOKIE_MAX_AGEand assertsverifySessionValuereturnsnull.README.md: Correct the security note — authorization is resolved bysession.emaillookup, notsub→ user ID binding.Tests updated (
roles.test.ts,profile.test.ts) to reflect new behavior (noorgNamein roles payload;metais a JSON string that must be parsed before asserting on its fields).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.