Copilot/fix typecheck errors map app#146
Merged
evanpetzoldt merged 2 commits intoroutes-instance-att-tagfrom Feb 24, 2026
Merged
Copilot/fix typecheck errors map app#146evanpetzoldt merged 2 commits intoroutes-instance-att-tagfrom
evanpetzoldt merged 2 commits intoroutes-instance-att-tagfrom
Conversation
…fic org schemas Co-authored-by: taterhead247 <26818765+taterhead247@users.noreply.github.com>
Contributor
Author
|
@evanpetzoldt AI found what was breaking typecheck. Can you please see if this messes up any of your stuff? if not, we can merge it into your branch/PR and then get it into dev after positive testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #142 added nullable overrides (
description,website,twitter,facebook,instagram,email) toOrgInsertSchema, which tightened those field types fromstring | null | undefinedtostring | null. Sinceorg.crupdateusesOrgInsertSchemaas its input, the mutation's inferred input type no longer acceptedundefinedfor these fields — but the specific org schemas used in the map app forms (AOInsertSchema,AreaInsertSchema,RegionInsertSchema,SectorInsertSchema,NationInsertSchema) were not updated, leaving them typed as optional (string | null | undefined). TypeScript flagged the mismatch at everymutateAsynccall site.Changes
packages/validators/src/index.tsevent-instance,attendance, andevent-tags#142's validator additions:eventTags/slackSpaces/slackUsersimports,EventTagschemas,eventTagIdsonEventInsertSchema,OrgInsertSchemanullable overrides, and Slack schemasdescription,email,website,twitter,facebook,instagram) to all five specific org schemas so their inferred types matchOrgInsertSchemapackages/api/src/router/org.test.ts/packages/api/src/lib/webhook-events.test.ts— updatesorg.crupdatecall sites to explicitly passdescription: null, website: null, twitter: null, facebook: null, instagram: null(matching the updated input type, mirrors PR New routes forevent-instance,attendance, andevent-tags#142's test changes)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.