Open
Conversation
…zando componente Blockimg, ancho y alto
…padding de formLogin
MMarussi
requested changes
Apr 7, 2020
briangerez
reviewed
Apr 7, 2020
Collaborator
briangerez
left a comment
briangerez
left a comment
There was a problem hiding this comment.
Excelente trabajo! 🎉 Te dejo algunos comentarios y sugerencias!
src/screens/LoginScreen/components/WhiteButton/index.module.scss
Outdated
Show resolved
Hide resolved
briangerez
reviewed
Apr 7, 2020
agregué sugerencia de tincho, cambié disable a disabled Co-Authored-By: MMarussi <jmmarussi32@gmail.com>
de acuerdo a sugerencia de Tincho, use cammelCase para modificar el nombre de un contenedor Co-Authored-By: MMarussi <jmmarussi32@gmail.com>
…io es el de WhiteButton
Tomo sugerencia de Tincho: No es necesario especificar que recibe un evento como parametro ya que es un parámetro implícito. Co-Authored-By: MMarussi <jmmarussi32@gmail.com>
…o al exportar está configurado
…erentes estados, pulleé cambios sugeridos por el PR
MMarussi
reviewed
Apr 8, 2020
briangerez
requested changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maqueté pantalla login.
Hice pantalla login con manejo de errores tanto en usuario, como en código de ingreso. Ambos muestran error en caso de estar incompleto 1 o ambos.
Además uní login con API.
Screenshots
Invision
https://projects.invisionapp.com/d/#/console/19366632/404500026/preview
https://projects.invisionapp.com/d/#/console/19366632/404500027/preview
https://projects.invisionapp.com/d/#/console/19366632/404500028/preview
Trello
https://trello.com/c/EKO6xGS5/2-maquetar-login
https://trello.com/c/BHjxRidh/6-manejo-de-errores-login
https://trello.com/c/ELThsc50/4-login-contra-backend