[Viewer] Enhance Molstar state management by improving code readability #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
Previously
MolecularStructure.tsxwas helding all the logic for PdbeMolstar plugin. We previously made an effort to extract the state into two useHooks ->usePdbPlugin()andusePluginRef(). But that effort wasn't enough as there is a lot of complexity still being held. Due to that complexity, when refined models feature was added, two bugs appeared:MolstarStateRefcausing to repeatedly load several instances of the model (duplications)This PR is a mid-refactor. It's a mid effort of extracting and moving some complexity out and improving readability while solving these mentioned bugs. And this PR isn't even the correct boilerplate of the refactor itself.