Skip to content

Conversation

@Martinski4GitHub
Copy link
Collaborator

Some code improvements and fine-tuning.

Some code improvements and fine-tuning.
@ExtremeFiretop ExtremeFiretop merged commit 457dc41 into ExtremeFiretop:dev Aug 3, 2025
1 check passed
@ExtremeFiretop
Copy link
Owner

I just submitted a PR with some code improvements & fine-tuning to make the code easier to read and maintain. There were just too many (and unnecessary) escaped sequences in some of the regular expressions feeding grep and sed cmds. Now the code is much easier to read and to quickly follow the logic, IMO :>)

Please take a look at and review the code when you get a chance, especially since you have a Gnuton-supported router to test & verify.

I've completed the code review, was pretty easy and nothing to flag as a concern with the cleanup :)
I'll load it up now on my Gnuton router to validate!

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Aug 4, 2025

Functional on my Gnuton router as seen below:
I've confirmed the links it's grabbing are the correct ones! :)

image

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Aug 4, 2025

@Martinski4GitHub

Also just wanted to add the fact that it appears the beta switch is working as intended.
The screenshot above was with the default "Beta-to-release" enabled.

Then if I disable it I now get this as expected:

image

@ExtremeFiretop
Copy link
Owner

Same thing with the switch in Merlin mode:
I think we are good for the next release! :)

image

@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,
Great testing and validation!!
Thanks, bud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants