Skip to content

Conversation

@ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented Aug 1, 2025

Suggested Fix by @cdavis5e from PR: #499
Just with some logic tweaks to make it compatible with PR: #498

@ExtremeFiretop ExtremeFiretop marked this pull request as ready for review August 1, 2025 14:41
@ExtremeFiretop ExtremeFiretop merged commit a0f5f85 into dev Aug 1, 2025
3 checks passed
@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-Suggested-Fix branch August 1, 2025 14:45
@ExtremeFiretop
Copy link
Owner Author

@Martinski4GitHub

FB_IMG_1754100446075

@Martinski4GitHub
Copy link
Collaborator

@Martinski4GitHub

FB_IMG_1754100446075

LOL!!! 😆😃😜

@Martinski4GitHub
Copy link
Collaborator

Martinski4GitHub commented Aug 3, 2025

Suggested Fix by @cdavis5e from PR: #499 Just with some logic tweaks to make it compatible with PR: #498

I'd like to make a couple of changes to that part of the code. The implementation does work, but it could be "cleaner" and just a bit more "elegant." Give me ~30 minutes to modify and run some quick tests.

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Aug 3, 2025

Suggested Fix by @cdavis5e from PR: #499 Just with some logic tweaks to make it compatible with PR: #498

I'd like to make a couple of changes to that part of the code. The implementation does work, but it could be "cleaner" and just a bit more "elegant." Give me ~30 minutes to modify and run some quick tests.

Absolutely buddy go for it. I'm assuming we should be almost ready for a new release?
The only thing I'd like to fully test is the Beta-to-production switch again. (Which took a new form/implementation)

@Martinski4GitHub
Copy link
Collaborator

Martinski4GitHub commented Aug 3, 2025

Suggested Fix by @cdavis5e from PR: #499 Just with some logic tweaks to make it compatible with PR: #498

I'd like to make a couple of changes to that part of the code. The implementation does work, but it could be "cleaner" and just a bit more "elegant." Give me ~30 minutes to modify and run some quick tests.

Absolutely buddy go for it. I'm assuming we should be almost ready for a new release?

I just submitted a PR with some code improvements & fine-tuning to make the code easier to read and maintain.
There were just too many (and unnecessary) escaped sequences in some of the regular expressions feeding grep and sed cmds. Now the code is much easier to read and to quickly follow the logic, IMO :>)

Please take a look at and review the code when you get a chance, especially since you have a Gnuton-supported router to test & verify.

I think after this PR, MerlinAU will be ready for the next release.

The only thing I'd like to fully test is the Beta-to-production switch again. (Which took a new form/implementation)

Sounds good, bud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants