feat: surface remote_owner in component list + warn on WordPress deploy#936
Merged
feat: surface remote_owner in component list + warn on WordPress deploy#936
Conversation
…oy (#602) Two changes to prevent the 'files deployed as root:root' footgun: 1. component list: always include remote_owner in JSON output (explicit null when unset) so missing config is visible at a glance. 2. deploy: warn when deploying to a wp-content/ path without remote_owner configured, with the exact fix command in the message.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #602 — makes
remote_ownervisible so missing config doesn't silently break WordPress deployments.Changes
1.
component listalways showsremote_ownerBefore:
remote_ownerwas omitted from JSON whenNone(serdeskip_serializing_if).After: explicitly
nullin list output, making it easy to spot missing config:{ "id": "data-machine", "remote_owner": null, // ← now visible "remote_path": "wp-content/plugins/data-machine" }The
skip_serializing_ifonRawComponentis unchanged —homeboy.jsonfiles won't get polluted with"remote_owner": null.2. Deploy warning for WordPress paths
When deploying to a
wp-content/path withoutremote_owner, a warning is logged with the exact fix command:Context
Root cause of the original issue:
fix_deployed_ownership()auto-detects ownership from existing files, but on first deploy the directory doesn't exist yet — files end up asroot:root, breaking WordPress.