Refactor and revise Python module name #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThreeMonth03
left a comment
ThreeMonth03
left a comment
There was a problem hiding this comment.
These suggestions may make your code clean.
By the way, maybe you should present making issues, pulling requests and cleaning codes.
Comment on lines
37
to
+50
| void print_dims_vec(const std::vector<int64_t> &dims) { | ||
| std::cout << "["; | ||
| for (size_t i = 0; i < dims.size() - 1; ++i) { | ||
| std::cout << dims[i] << ", "; | ||
| } | ||
| std::cout << dims.back() << "]"; | ||
| std::cout << "["; | ||
| for (size_t i = 0; i < dims.size() - 1; ++i) { | ||
| std::cout << dims[i] << ", "; | ||
| } | ||
| std::cout << dims.back() << "]"; | ||
| } | ||
|
|
||
| std::string dims_vec_to_str(const std::vector<int64_t> &dims) { | ||
| std::string str = "["; | ||
| for (size_t i = 0; i < dims.size() - 1; ++i) { | ||
| str += std::to_string(dims[i]) + ", "; | ||
| } | ||
| str += std::to_string(dims.back()) + "]"; | ||
| std::string str = "["; | ||
| for (size_t i = 0; i < dims.size() - 1; ++i) { | ||
| str += std::to_string(dims[i]) + ", "; | ||
| } | ||
| str += std::to_string(dims.back()) + "]"; |
There was a problem hiding this comment.
Consider using ofstream to prevent programming the similar function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title