Skip to content
This repository was archived by the owner on Dec 6, 2018. It is now read-only.

Conversation

@tyllrb
Copy link
Contributor

@tyllrb tyllrb commented Jan 10, 2018

Not sure if we're completely removing support for sub ES6 javascript flavours? If so I can delete the es6 conditionals in templates/sections/bigwheel/normal/index.js and templates/sections/preloader/index.js, as well as any other conditionals relating to es6 wherever they may be.

@njam3
Copy link
Member

njam3 commented Jan 10, 2018

@tyllrb Yeah, we want to remove all references to the useES6 prompt, so anywhere you see {{useES6}} or gen.config.get('useES6') you would want to remove the conditional and leave the code of the true conditionals. We basically want to have the templates reflect a useES6 = true state.

@tyllrb tyllrb force-pushed the chore/remove-es6-prompt branch from 5721aed to 520fb24 Compare January 16, 2018 17:45
@tyllrb
Copy link
Contributor Author

tyllrb commented Jan 16, 2018

cool 👍 updated the PR -- got rid of any conditionals relating to whether or not ES6 is true or not, also the index.js files in templates/sections/bigwheel/* now use classes instead of extending the function prototype namespace.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants