Replace `FullScreenLoadingIndicator` with `ActivityIndicator` in image components #76001

abzokhattab · 2025-11-25T10:34:39Z

Explanation of Change

Fixed Issues

$ #74935
PROPOSAL:

Tests

Test 1: Image Loading Spinner in Full Image View
Steps:

Open the app and navigate to a chat/report with an attached image
Tap on the image to open it in full-screen view
Observe the loading behavior (on slower connections or large images) and validate that the loading spinner have the same style as in prod and the go back button is not shown after 10sec of loading

Test 2: Thumbnail Image Loading in Chat/Report
Steps:

Navigate to a conversation or expense report with image attachments
Scroll to see image thumbnails load (especially on slower network or first load)
Observe the loading behavior (on slower connections or large images) and validate that the loading spinner have the same style as in prod and the go back button is not shown after 10sec of loading

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-15.at.00.36.42.mov

Android: mWeb Chrome

Screen.Recording.2025-12-15.at.00.37.41.mov

iOS: Native

Screen.Recording.2025-12-15.at.00.00.30.mov

iOS: mWeb Safari

Screen.Recording.2025-12-15.at.00.35.41.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-14.at.23.58.15.mov

codecov · 2025-11-25T10:42:39Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Image/index.tsx	`61.42% <ø> (ø)`
src/components/ImageWithLoading.tsx	`76.19% <ø> (ø)`
.../components/MoneyRequestConfirmationListFooter.tsx	`84.21% <100.00%> (-0.06%)`	⬇️
src/components/PDFThumbnail/index.native.tsx	`0.00% <ø> (ø)`
src/components/PDFView/index.native.tsx	`8.00% <ø> (-1.10%)`	⬇️
src/components/PDFView/index.tsx	`0.00% <ø> (ø)`
src/components/ImageView/index.tsx	`0.00% <0.00%> (ø)`
src/components/PDFThumbnail/index.tsx	`0.00% <0.00%> (ø)`
src/components/LoadingIndicator.tsx	`25.00% <25.00%> (ø)`
... and 85 files with indirect coverage changes

…mponents

…dicator

melvin-bot · 2025-12-15T00:00:17Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abzokhattab · 2025-12-15T00:03:13Z

@Julesssss here is the second PR after this #75031

abzokhattab · 2025-12-15T00:25:00Z

@Julesssss Since all of the new refactorings have the same styling that were in the FullscreenLoadingIndicator so instead of duplicating the styling over and over .. i created a shared component to be used and provide a cleaner code

Applied them on the PDF loaders as well.

abzokhattab · 2025-12-15T00:29:00Z

There was also a bug in the loading indicator when creating an expense is not centered

Screen.Recording.2025-12-14.at.23.22.12.mov

so this is now fixed after using the shared component:

Screen.Recording.2025-12-15.at.01.28.09.mov

bernhardoj · 2025-12-15T02:48:03Z

Is C+ needed here?

JmillsExpensify

Product review not strictly required.

Julesssss · 2025-12-22T21:25:01Z

Is C+ needed here?

Yes, please go ahead @bernhardoj

bernhardoj · 2025-12-23T02:45:36Z

@abzokhattab please merge with main

…dicator

abzokhattab · 2025-12-23T08:53:12Z

There u go @bernhardoj

src/components/PDFView/index.tsx

…dicator

bernhardoj · 2025-12-24T04:02:16Z

There was also a bug in the loading indicator when creating an expense is not centered

@abzokhattab I changed the pdf code so that it always shows the loading, but I can't seem to see the LoadingIndicator. If I change it to simple Text, then the text shows. Please see the video below:

web.mp4

bernhardoj · 2025-12-24T04:04:40Z

From the 1st video, we can see there are 2 loading indicators

But from the 2nd video, the loading indicator of the PDF is missing.

bernhardoj · 2025-12-24T04:07:49Z

src/components/LoadingIndicator.tsx

+    const styles = useThemeStyles();
+
+    return (
+        <View style={[StyleSheet.absoluteFillObject, styles.fullScreenLoading, styles.w100, style]}>


If I remove the absolute style, then the loading indicator shows. Btw, I noticed that the structure here looks the same as the FullScreenLoadingIndicator, just without a back button. Maybe we should keep using plain ActivityIndicator for the pdf?

I think its just cleaner this way since most of the instances are using the same styling inside the the Loading indicator so i believe its worth it to have this new component

Or we can keep the full screen loading indicator and add a param that would disable the backTo

What do you think

Or we can keep the full screen loading indicator and add a param that would disable the backTo

This is what is already happening right now, that's why we won't see the back button even without this PR, actually, but it's only temporary.

App/src/components/FullscreenLoadingIndicator.tsx

Line 35 in 2dcf2fc

shouldUseGoBackButton = false,

App/src/components/FullscreenLoadingIndicator.tsx

Lines 62 to 72 in 2dcf2fc

{showGoBackButton && (

<View style={styles.loadingMessage}>

<View style={styles.pv4}>

<Text>{translate('common.thisIsTakingLongerThanExpected')}</Text>

</View>

<Button

text={translate('common.goBack')}

onPress={() => Navigation.goBack()}

/>

</View>

)}

I think its just cleaner this way since most of the instances are using the same styling inside the the Loading indicator so i believe its worth it to have this new component

I don't think there are that many components that show a loading indicator with this structure, but I get your point that most of the time, we want to show a loading indicator that is shown in the center, so I'm fine to keep the component, but we still need to fix the loading indicator on the PDF components.

Okay i fixed the loader for the pdf:

screen-recording-2025-12-24-at-184822_at52s52W.mov

Hmm, I'm still unable to see it. Maybe there is some code that you forgot to push?

web.mp4

can you check now ... here is what i have

Screen.Recording.2025-12-27.at.10.32.25.mov

bernhardoj · 2025-12-24T04:21:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

…dicator

bernhardoj · 2025-12-29T01:16:57Z

src/components/MoneyRequestConfirmationListFooter.tsx

                        accessibilityLabel={translate('accessibilityHints.viewAttachment')}
                        disabled={!shouldDisplayReceipt}
                        disabledStyle={styles.cursorDefault}
+                        style={[styles.h100, styles.flex1]}


From my testing, we don't need the flex1 style here.

bernhardoj · 2025-12-29T01:17:09Z

src/components/MoneyRequestConfirmationListFooter.tsx

                        <PDFThumbnail
                            // eslint-disable-next-line @typescript-eslint/non-nullable-type-assertion-style
                            previewSourceURL={resolvedReceiptImage as string}
+                            style={[styles.w100, styles.h100]}


From my testing, we don't need the w100 style here.

NAB: we can even remove the h100 style here and here

App/src/components/ReceiptImage/index.tsx

Lines 174 to 178 in b8ece4b

if (isPDFThumbnail) {

return (

<PDFThumbnail

previewSourceURL={source ?? ''}

style={[styles.w100, styles.h100]}

Then, we can always apply the h100 here instead of only when it fails

App/src/components/PDFThumbnail/index.tsx

Lines 57 to 58 in b8ece4b

return (

<View style={[style, styles.overflowHidden, failedToLoad && styles.h100]}>

and move the style prop to the last item of the array.

hmmm i removed the w100 but i see that most of the occureneces have both styles.w100, styles.h100 i am not sure if we should remove that but can u please check if it will cause any regressions ...

i am fine with changing the App/src/components/ReceiptImage/index.tsx and PDFThumbnail/index.tsx but lets see if it will cause any issues

bernhardoj · 2025-12-29T01:48:30Z

Please also fix the lint, and we are good.

melvin-bot bot assigned abzokhattab Nov 25, 2025

abzokhattab mentioned this pull request Nov 25, 2025

Use correct loading indicators in image components #74935

Open

Replace FullscreenLoadingIndicator with ActivityIndicator in Image co…

955a17a

…mponents

abzokhattab force-pushed the fix/image-activity-indicator branch from 4e10c9f to 955a17a Compare November 25, 2025 14:33

abzokhattab added 3 commits December 1, 2025 19:06

Merge remote-tracking branch 'origin/main' into fix/image-activity-in…

787d0f4

…dicator

Merge remote-tracking branch 'origin/main' into fix/image-activity-in…

a51e8fe

…dicator

Refactoring

d86de56

abzokhattab marked this pull request as ready for review December 15, 2025 00:00

abzokhattab requested review from a team as code owners December 15, 2025 00:00

melvin-bot bot requested review from JmillsExpensify and bernhardoj and removed request for a team December 15, 2025 00:00

melvin-bot bot removed the request for review from a team December 15, 2025 00:00

feat: add LoadingIndicator component for consistent loading UI

1fa91a2

abzokhattab added 3 commits December 15, 2025 01:30

fixing eslint

0cd46d9

minor edit

dc401c5

minor refactor change size to iconSize

08ffded

JmillsExpensify reviewed Dec 18, 2025

View reviewed changes

Julesssss self-requested a review December 22, 2025 21:24

Merge remote-tracking branch 'origin/main' into fix/image-activity-in…

a759239

…dicator

bernhardoj reviewed Dec 23, 2025

View reviewed changes

src/components/PDFView/index.tsx Outdated Show resolved Hide resolved

abzokhattab added 2 commits December 24, 2025 00:12

PDFView loader refactoring

60a9555

Merge remote-tracking branch 'origin/main' into fix/image-activity-in…

3cb2902

…dicator

abzokhattab requested a review from bernhardoj December 23, 2025 23:13

bernhardoj reviewed Dec 24, 2025

View reviewed changes

abzokhattab added 3 commits December 24, 2025 18:49

fix: making PDF laoding indicator centered

0afcb8e

Merge remote-tracking branch 'origin/main' into fix/image-activity-in…

8a2e6e8

…dicator

fix: center PDF loading indicator in expense creation

dc6c45e

abzokhattab requested a review from bernhardoj December 27, 2025 09:43

bernhardoj reviewed Dec 29, 2025

View reviewed changes

abzokhattab added 2 commits December 29, 2025 03:40

refactoring and fixing lint

35446f1

fixing eslint

1146a55

	{showGoBackButton && (
	<View style={styles.loadingMessage}>
	<View style={styles.pv4}>
	<Text>{translate('common.thisIsTakingLongerThanExpected')}</Text>
	</View>
	<Button
	text={translate('common.goBack')}
	onPress={() => Navigation.goBack()}
	/>
	</View>
	)}

	if (isPDFThumbnail) {
	return (
	<PDFThumbnail
	previewSourceURL={source ?? ''}
	style={[styles.w100, styles.h100]}

	return (
	<View style={[style, styles.overflowHidden, failedToLoad && styles.h100]}>

Replace FullScreenLoadingIndicator with ActivityIndicator in image components #76001

Are you sure you want to change the base?

Replace FullScreenLoadingIndicator with ActivityIndicator in image components #76001

Conversation

abzokhattab commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 15, 2025

Uh oh!

abzokhattab commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Dec 15, 2025

Uh oh!

bernhardoj commented Dec 15, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Dec 22, 2025

Uh oh!

bernhardoj commented Dec 23, 2025

Uh oh!

abzokhattab commented Dec 23, 2025

Uh oh!

Uh oh!

bernhardoj commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Dec 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Replace `FullScreenLoadingIndicator` with `ActivityIndicator` in image components #76001

Replace `FullScreenLoadingIndicator` with `ActivityIndicator` in image components #76001

abzokhattab commented Nov 25, 2025 •

edited

Loading

codecov bot commented Nov 25, 2025 •

edited by github-actions bot

Loading

abzokhattab commented Dec 15, 2025 •

edited

Loading

abzokhattab commented Dec 15, 2025 •

edited

Loading

bernhardoj commented Dec 24, 2025 •

edited

Loading

bernhardoj commented Dec 24, 2025 •

edited

Loading